linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBIFS: add crypto lookup field to tree node cache
Date: Mon, 14 May 2012 16:21:56 +0300	[thread overview]
Message-ID: <1337001716.2528.56.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205111323010.17715@eristoteles.iwoars.net>

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

On Fri, 2012-05-11 at 13:24 +0200, Joel Reardon wrote:
>  struct ubifs_zbranch {
>  	union ubifs_key key;
> @@ -751,6 +752,7 @@ struct ubifs_zbranch {
>  	int lnum;
>  	int offs;
>  	int len;
> +	long long crypto_lookup;
>  };

Why is it "long long" which is 64 bit? What will it contain? Could we
make it unsigned int - we'd waste less RAM then - remember that we
allocate a lot of these structures.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-05-14 13:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 11:24 [PATCH] UBIFS: add crypto lookup field to tree node cache Joel Reardon
2012-05-14 13:21 ` Artem Bityutskiy [this message]
2012-05-14 17:20   ` Joel Reardon
2012-05-14 18:28     ` Artem Bityutskiy
2012-05-14 18:45       ` Joel Reardon
2012-05-14 19:14         ` Artem Bityutskiy
2012-05-15  6:21 ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1337001716.2528.56.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=joel@clambassador.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).