From: David Woodhouse <dwmw2@infradead.org>
To: Daniel Drake <dsd@laptop.org>
Cc: dilinger@queued.net, linux-mtd@lists.infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH] JFFS2: Add parameter to reserve disk space for root
Date: Tue, 15 May 2012 16:06:44 +0100 [thread overview]
Message-ID: <1337094404.4170.72.camel@shinybook.infradead.org> (raw)
In-Reply-To: <20120410212235.951079D401E@zog.reactivated.net>
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
On Tue, 2012-04-10 at 22:22 +0100, Daniel Drake wrote:
>
> + /* Always allow root */
> + if (current_fsuid() == 0 || current_fsgid() == 0)
> + return 1;
I've changed that to if (capable(CAP_SYS_RESOURCE)) rather than having a
hard-coded check for the root user, which is usually the wrong thing to
do. Please test.
--
dwmw2
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]
next prev parent reply other threads:[~2012-05-15 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 21:22 [PATCH] JFFS2: Add parameter to reserve disk space for root Daniel Drake
2012-04-22 12:19 ` Artem Bityutskiy
2012-04-22 13:15 ` Artem Bityutskiy
2012-05-15 15:06 ` David Woodhouse [this message]
2012-05-15 18:06 ` Daniel Drake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337094404.4170.72.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=dedekind1@gmail.com \
--cc=dilinger@queued.net \
--cc=dsd@laptop.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox