Re: [PATCH] ubi: add volume id and LEB number to struct ubi_scan_leb

[Artem Bityutskiy <dedekind1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]

On Wed, 2012-05-16 at 14:20 +0200, Joel Reardon wrote:
> This patch adds the volume id and LEB number to struct ubi_scan_leb when
> scanning the LEBs at startup.  PEBs now added to the erase queue will know
> their original LEB number and volume id, if available, and will be -1
> otherwise (for instance, if the vid header is unreadable).
> 
> This was tested by creating an ubi device with 3 volumes and disabiling the
> ubi_thread's do_work functionality. The different ubi volumes were formatted
> to ubifs and had files created and erased.  The ubi modules was reloaded and
> the list of LEB's added to the erased list was outputted, confirming the
> volume ids and LEB numbers were appropriate.
> 
> Signed-off-by: Joel Reardon <reardonj@inf.ethz.ch>

I've added this code to the joel branch. But please, test this and other
UBI merge candidates with all the UBI debugging checks enabled as well.
Similar to UBIFS.

Well, I mean, I am willing to merge this feature upstream as soon as it
is in good shape, even if your crypto code is never merged. So testing
with debugging enabled should be done. For various small patches you
send which will land in the joel branch - I do not care much - test with
debugging enabled just sometimes.

Anyway, this patch is in "joel", once the whole features is there, I'll
move it to "master". So you could give this feature more priority for
now.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]