From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] UBIFS: read crypto_lookup from datanodes to znodes
Date: Sat, 19 May 2012 14:00:33 +0300 [thread overview]
Message-ID: <1337425233.2041.17.camel@koala> (raw)
In-Reply-To: <alpine.DEB.2.00.1205191027340.18672@eristoteles.iwoars.net>
[-- Attachment #1: Type: text/plain, Size: 489 bytes --]
On Sat, 2012-05-19 at 10:30 +0200, Joel Reardon wrote:
> + crypto_lookup = le64_to_cpu(dn->crypto_lookup);
> + if (zbr->crypto_lookup != 0)
> + ubifs_assert(zbr->crypto_lookup ==
> + crypto_lookup);
This "crypto_lookup" name is too long. Would you mind if we re-name it
to "ksa_pos" instead (KSA position)? Then we'll wrap less lines.
We can do this as a separate patch on top of this one. How does this
sound to you?
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-19 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-15 9:01 [PATCH] UBIFS: read crypto_lookup from datanodes to znodes Joel Reardon
2012-05-15 13:03 ` Artem Bityutskiy
2012-05-16 12:52 ` [PATCH v2] " Joel Reardon
2012-05-18 13:23 ` Artem Bityutskiy
2012-05-19 8:30 ` [PATCH v3] " Joel Reardon
2012-05-19 11:00 ` Artem Bityutskiy [this message]
2012-05-19 11:34 ` Artem Bityutskiy
2012-05-20 11:35 ` [patch] UBIFS: improved comment for data node's format history Joel Reardon
2012-05-20 18:34 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337425233.2041.17.camel@koala \
--to=dedekind1@gmail.com \
--cc=joel@clambassador.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox