From: Artem Bityutskiy <dedekind1@gmail.com>
To: Johan Gunnarsson <johan.gunnarsson@axis.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Jesper Nilsson <jespern@axis.com>
Subject: RE: [PATCH 2/2] mtd: nand: use hrtimer to measure timeout in nand_wait{_ready, }
Date: Tue, 22 May 2012 13:25:28 +0300 [thread overview]
Message-ID: <1337682328.2483.144.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <A612847CFE53224C91B23E3A5B48BAC7534B129D18@xmail3.se.axis.com>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Tue, 2012-05-22 at 10:52 +0200, Johan Gunnarsson wrote:
> Not an expert on the MTD framework -- but I believe the 400 comes from
> the comment above nand_wait(): "Wait for command done. This applies to
> erase and program only. Erase can take up to 400ms and program up to
> 20ms according to general NAND and SmartMedia specs."
Most probably this legacy can be killed along with the IPAQ h1910 driver
you pointed. But could you please start with cleaning these functions up
and turning the "!chip->dev_ready()" case into a simple msleep() or
mdelay() for the panic case?
Then I may get some ideas how to get rid of the jiffies without using
hrtimer.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-05-22 10:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 8:42 [PATCH 0/2] use hrtimer in nand_wait Johan Gunnarsson
2012-05-21 8:42 ` [PATCH 1/2] mtd: nand: panic_nand_wait expects timeout in ms Johan Gunnarsson
2012-05-21 8:42 ` [PATCH 2/2] mtd: nand: use hrtimer to measure timeout in nand_wait{_ready, } Johan Gunnarsson
2012-05-22 7:53 ` Artem Bityutskiy
2012-05-22 8:52 ` Johan Gunnarsson
2012-05-22 10:25 ` Artem Bityutskiy [this message]
2012-05-22 14:24 ` Johan Gunnarsson
2012-05-22 17:10 ` Ivan Djelic
2012-05-22 18:21 ` Artem Bityutskiy
2012-05-23 6:39 ` Brian Norris
2012-05-23 8:36 ` Ivan Djelic
2012-05-23 8:14 ` Johan Gunnarsson
2012-05-22 7:23 ` [PATCH 0/2] use hrtimer in nand_wait Artem Bityutskiy
2012-05-22 8:37 ` Johan Gunnarsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337682328.2483.144.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=jespern@axis.com \
--cc=johan.gunnarsson@axis.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).