linux-mtd.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Joel Reardon <joel@clambassador.com>
Cc: MTD Maling List <linux-mtd@lists.infradead.org>
Subject: [PATCH 1/4] UBIFS: correction to Joels' patch
Date: Thu,  7 Jun 2012 12:06:05 +0300	[thread overview]
Message-ID: <1339059968-25753-1-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1206062052140.31834@eristoteles.iwoars.net>

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

This is a nit-pick, and yes, I am paranoid, but in UBIFS we try to put
variables of the same type together when declaring them. Here is the correction
- please, take this into account in later patches.

Thanks!

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 fs/ubifs/sb.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c
index c1665ca..d4328bd 100644
--- a/fs/ubifs/sb.c
+++ b/fs/ubifs/sb.c
@@ -81,8 +81,7 @@ static int create_default_filesystem(struct ubifs_info *c)
 	union ubifs_key key;
 	int err, tmp, jnl_lebs, log_lebs, max_buds, main_lebs, main_first;
 	int lpt_lebs, lpt_first, orph_lebs, big_lpt, ino_waste, sup_flags = 0;
-	int min_leb_cnt = UBIFS_MIN_LEB_CNT;
-	int ksa_lebs = 0, ksa_first;
+	int min_leb_cnt = UBIFS_MIN_LEB_CNT, ksa_lebs = 0, ksa_first;
 	long long tmp64, main_bytes;
 	__le64 tmp_le64;
 
@@ -370,9 +369,7 @@ static int create_default_filesystem(struct ubifs_info *c)
 static int validate_sb(struct ubifs_info *c, struct ubifs_sb_node *sup)
 {
 	long long max_bytes;
-	int err = 1, min_leb_cnt;
-	int max_ksa_leb_cnt;
-	int min_ksa_leb_cnt;
+	int err = 1, min_leb_cnt, max_ksa_leb_cnt, min_ksa_leb_cnt;
 
 	if (!c->key_hash) {
 		err = 2;
-- 
1.7.10

  reply	other threads:[~2012-06-07  9:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-25 13:10 [PATCH] UBIFS: compute KSA size and store in superblock Joel Reardon
2012-05-25 13:24 ` Artem Bityutskiy
2012-05-26 11:21   ` Joel Reardon
2012-05-26 13:31     ` Artem Bityutskiy
2012-05-30 13:32   ` [PATCH v2] " Joel Reardon
2012-05-30 15:18     ` Artem Bityutskiy
2012-05-31 10:12       ` Joel Reardon
2012-05-31 10:19         ` Artem Bityutskiy
2012-05-31 10:36           ` Artem Bityutskiy
2012-06-06 10:03             ` [PATCH v3] " Joel Reardon
2012-06-06 14:30               ` Artem Bityutskiy
2012-06-06 18:52               ` [PATCH v4] " Joel Reardon
2012-06-07  9:06                 ` Artem Bityutskiy [this message]
2012-06-07  9:06                   ` [PATCH 2/4] UBIFS: another correction to joel's patch Artem Bityutskiy
2012-06-07  9:06                   ` [PATCH 3/4] UBIFS: improvement to Joel's patch Artem Bityutskiy
2012-06-07  9:06                   ` [PATCH 4/4] UBIFS: add TOTOs for Joel Artem Bityutskiy
2012-06-07  9:10                 ` [PATCH v4] UBIFS: compute KSA size and store in superblock Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1339059968-25753-1-git-send-email-dedekind1@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=joel@clambassador.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).