From: Artem Bityutskiy <dedekind1@gmail.com>
To: Scott Wood <scottwood@freescale.com>
Cc: linux-mtd@lists.infradead.org, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: elbc nand: use drvdata to only remove the relevant chip
Date: Thu, 07 Jun 2012 13:08:42 +0300 [thread overview]
Message-ID: <1339063722.6875.94.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20120606233639.GA13977@tyr.buserror.net>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Wed, 2012-06-06 at 18:36 -0500, Scott Wood wrote:
> Previously the remove method was looping and removing all chips,
> which is obviously not the right thing to do -- left over from when
> the driver was organized differently and that was the remove method for
> the entire controller. This would result in bad things happening if
> you have more than one NAND chip, and remove the module.
>
> This also fixes priv->dev to properly point to the chip's device rather than
> the controller's. Until now priv->dev was only used for error/debug prints
> (and it's an improvement there), so this shouldn't break anything.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-07 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 23:36 [PATCH] mtd: elbc nand: use drvdata to only remove the relevant chip Scott Wood
2012-06-07 10:08 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339063722.6875.94.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).