From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <1340768981.2317.7.camel@koala> Subject: Re: [PATCH v11 0/4] MTD: at91: Add PMECC support for at91 nand flash driver From: Artem Bityutskiy To: Josh Wu Date: Wed, 27 Jun 2012 06:49:41 +0300 In-Reply-To: <1340618866-28776-1-git-send-email-josh.wu@atmel.com> References: <1340618866-28776-1-git-send-email-josh.wu@atmel.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-eQva3IeyZFgog+5NGU+s" Mime-Version: 1.0 Cc: hongxu.cn@gmail.com, jack.lan@freescale.com, nick.spence@freescale.com, tie-fei.zang@freescale.com, nicolas.ferre@atmel.com, dwmw2@infradead.org, linux-mtd@lists.infradead.org, scottwood@freescale.com, Dipen.Dudhat@freescale.com, ivan.djelic@parrot.com, computersforpeace@gmail.com, plagnioj@jcrosoft.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, bryan.wu@analog.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --=-eQva3IeyZFgog+5NGU+s Content-Type: multipart/mixed; boundary="=-ZP2iOCOGIPAIjeAPBkCW" --=-ZP2iOCOGIPAIjeAPBkCW Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2012-06-25 at 18:07 +0800, Josh Wu wrote: > Those patches is based on v3.5-rc4 >=20 > Changes since v10, > add one more patch in this patch set, which add 'int' return value for w= rite_page()/write_page_raw() functions in structure of nand_ecc_ctrl. > Instead of calling BUG(), atmel_nand_pmecc_write_page() will return -EIO= when time out to read the pmecc status register. > increase the time-out duration to 100ms, which has more toleration. > add oob_required argument for pmecc read/write functions to align with v= 3.5-rc4. I have issues compiling l2-mtd.git tree (based on 3.5-rc5) with the attached defconfig. Probably not your fault, but may be you have a fix/suggestion? I did not have time to look closer. Aiaiai reports: Failed to build the following commit for configuration "arm-at91cap9_defcon= fig" (architecture arm)": bb6ac5c Quick fixes - applied by aiaiai include/linux/math64.h:55:15: note: each undeclared identifier is reported = only once for each function it appears in In file included from include/linux/mm_types.h:16:0, from include/linux/sched.h:64, from arch/arm/kernel/asm-offsets.c:13: arch/arm/include/asm/page.h: At top level: arch/arm/include/asm/page.h:107:2: error: #error Unknown user operations mo= del In file included from include/linux/mm.h:44:0, from arch/arm/kernel/asm-offsets.c:14: arch/arm/include/asm/pgtable.h:198:5: warning: "__LINUX_ARM_ARCH__" is not = defined [-Wundef] In file included from arch/arm/include/asm/cacheflush.h:15:0, from arch/arm/kernel/asm-offsets.c:16: arch/arm/include/asm/glue-cache.h:129:2: error: #error Unknown cache mainte= nance model In file included from arch/arm/include/asm/cacheflush.h:17:0, from arch/arm/kernel/asm-offsets.c:16: arch/arm/include/asm/cachetype.h:28:5: warning: "__LINUX_ARM_ARCH__" is not= defined [-Wundef] arch/arm/include/asm/cachetype.h:33:7: warning: "__LINUX_ARM_ARCH__" is not= defined [-Wundef] In file included from arch/arm/kernel/asm-offsets.c:16:0: arch/arm/include/asm/cacheflush.h:194:7: warning: "__LINUX_ARM_ARCH__" is n= ot defined [-Wundef] arch/arm/include/asm/cacheflush.h:196:7: warning: "__LINUX_ARM_ARCH__" is n= ot defined [-Wundef] In file included from arch/arm/kernel/asm-offsets.c:17:0: arch/arm/include/asm/glue-df.h:99:2: error: #error Unknown data abort handl= er type In file included from arch/arm/kernel/asm-offsets.c:18:0: arch/arm/include/asm/glue-pf.h:54:2: error: #error Unknown prefetch abort h= andler type make[2]: *** [arch/arm/kernel/asm-offsets.s] Error 1 --=20 Best Regards, Artem Bityutskiy --=-ZP2iOCOGIPAIjeAPBkCW Content-Disposition: attachment; filename="arm-at91cap9_defconfig" Content-Transfer-Encoding: base64 Content-Type: text/plain; name="arm-at91cap9_defconfig"; charset="UTF-8" Q09ORklHX0VYUEVSSU1FTlRBTD15DQojIENPTkZJR19MT0NBTFZFUlNJT05fQVVUTyBpcyBub3Qg c2V0DQpDT05GSUdfU1lTVklQQz15DQpDT05GSUdfQlNEX1BST0NFU1NfQUNDVD15DQpDT05GSUdf TE9HX0JVRl9TSElGVD0xOA0KQ09ORklHX0NHUk9VUFM9eQ0KQ09ORklHX0NHUk9VUF9GUkVFWkVS PXkNCkNPTkZJR19DUFVTRVRTPXkNCkNPTkZJR19DR1JPVVBfQ1BVQUNDVD15DQpDT05GSUdfUkVT T1VSQ0VfQ09VTlRFUlM9eQ0KQ09ORklHX0NHUk9VUF9TQ0hFRD15DQpDT05GSUdfQkxLX0RFVl9J TklUUkQ9eQ0KIyBDT05GSUdfQ09NUEFUX0JSSyBpcyBub3Qgc2V0DQpDT05GSUdfUFJPRklMSU5H PXkNCkNPTkZJR19LUFJPQkVTPXkNCkNPTkZJR19NT0RVTEVTPXkNCkNPTkZJR19NT0RVTEVfVU5M T0FEPXkNCkNPTkZJR19NT0RVTEVfRk9SQ0VfVU5MT0FEPXkNCkNPTkZJR19QQVJUSVRJT05fQURW QU5DRUQ9eQ0KQ09ORklHX09TRl9QQVJUSVRJT049eQ0KQ09ORklHX0FNSUdBX1BBUlRJVElPTj15 DQpDT05GSUdfTUFDX1BBUlRJVElPTj15DQpDT05GSUdfQlNEX0RJU0tMQUJFTD15DQpDT05GSUdf TUlOSVhfU1VCUEFSVElUSU9OPXkNCkNPTkZJR19TT0xBUklTX1g4Nl9QQVJUSVRJT049eQ0KQ09O RklHX1VOSVhXQVJFX0RJU0tMQUJFTD15DQpDT05GSUdfU0dJX1BBUlRJVElPTj15DQpDT05GSUdf U1VOX1BBUlRJVElPTj15DQpDT05GSUdfS0FSTUFfUEFSVElUSU9OPXkNCkNPTkZJR19FRklfUEFS VElUSU9OPXkNCkNPTkZJR19BUkNIX0FUOTE9eQ0KQ09ORklHX01BQ0hfT05FQVJNPXkNCkNPTkZJ R19BUkNIX0FUOTFSTTkyMDBESz15DQpDT05GSUdfTUFDSF9BVDkxUk05MjAwRUs9eQ0KQ09ORklH X01BQ0hfQ1NCMzM3PXkNCkNPTkZJR19NQUNIX0NTQjYzNz15DQpDT05GSUdfTUFDSF9DQVJNRVZB PXkNCkNPTkZJR19NQUNIX0FURUI5MjAwPXkNCkNPTkZJR19NQUNIX0tCOTIwMD15DQpDT05GSUdf TUFDSF9QSUNPVFVYMlhYPXkNCkNPTkZJR19NQUNIX0tBRkE9eQ0KQ09ORklHX01BQ0hfRUNCQVQ5 MT15DQpDT05GSUdfTUFDSF9ZTDkyMDA9eQ0KQ09ORklHX01BQ0hfQ1BVQVQ5MT15DQpDT05GSUdf TUFDSF9FQ085MjA9eQ0KQ09ORklHX01BQ0hfUlNJX0VXUz15DQpDT05GSUdfTVREX0FUOTFfREFU QUZMQVNIX0NBUkQ9eQ0KQ09ORklHX0FUOTFfUFJPR1JBTU1BQkxFX0NMT0NLUz15DQpDT05GSUdf UENDQVJEPXkNCkNPTkZJR19OT19IWj15DQpDT05GSUdfSElHSF9SRVNfVElNRVJTPXkNCkNPTkZJ R19QUkVFTVBUX1ZPTFVOVEFSWT15DQpDT05GSUdfVVNFX09GPXkNCkNPTkZJR19LRVhFQz15DQpD T05GSUdfQ1JBU0hfRFVNUD15DQpDT05GSUdfQklORk1UX01JU0M9eQ0KIyBDT05GSUdfU1VTUEVO RCBpcyBub3Qgc2V0DQpDT05GSUdfVUVWRU5UX0hFTFBFUl9QQVRIPSIvc2Jpbi9ob3RwbHVnIg0K Q09ORklHX0RFQlVHX0RFVlJFUz15DQpDT05GSUdfTVREPXkNCkNPTkZJR19NVERfVEVTVFM9bQ0K Q09ORklHX01URF9SRURCT09UX1BBUlRTPW0NCkNPTkZJR19NVERfUkVEQk9PVF9QQVJUU19VTkFM TE9DQVRFRD15DQpDT05GSUdfTVREX1JFREJPT1RfUEFSVFNfUkVBRE9OTFk9eQ0KQ09ORklHX01U RF9DTURMSU5FX1BBUlRTPXkNCkNPTkZJR19NVERfQUZTX1BBUlRTPXkNCkNPTkZJR19NVERfT0Zf UEFSVFM9eQ0KQ09ORklHX01URF9BUjdfUEFSVFM9bQ0KQ09ORklHX01URF9DSEFSPXkNCkNPTkZJ R19NVERfQkxPQ0s9eQ0KQ09ORklHX0ZUTD1tDQpDT05GSUdfTkZUTD1tDQpDT05GSUdfTkZUTF9S Vz15DQpDT05GSUdfSU5GVEw9bQ0KQ09ORklHX1JGRF9GVEw9bQ0KQ09ORklHX1NTRkRDPXkNCkNP TkZJR19TTV9GVEw9bQ0KQ09ORklHX01URF9PT1BTPW0NCkNPTkZJR19NVERfU1dBUD15DQpDT05G SUdfTVREX0NGST1tDQpDT05GSUdfTVREX0pFREVDUFJPQkU9bQ0KQ09ORklHX01URF9DRklfQURW X09QVElPTlM9eQ0KQ09ORklHX01URF9DRklfR0VPTUVUUlk9eQ0KIyBDT05GSUdfTVREX01BUF9C QU5LX1dJRFRIXzEgaXMgbm90IHNldA0KQ09ORklHX01URF9NQVBfQkFOS19XSURUSF8xNj15DQoj IENPTkZJR19NVERfQ0ZJX0kxIGlzIG5vdCBzZXQNCkNPTkZJR19NVERfQ0ZJX0k0PXkNCkNPTkZJ R19NVERfT1RQPXkNCkNPTkZJR19NVERfQ0ZJX0lOVEVMRVhUPW0NCkNPTkZJR19NVERfQ0ZJX0FN RFNURD1tDQpDT05GSUdfTVREX0NGSV9TVEFBPW0NCkNPTkZJR19NVERfUk9NPW0NCkNPTkZJR19N VERfQUJTRU5UPW0NCkNPTkZJR19NVERfQ09NUExFWF9NQVBQSU5HUz15DQpDT05GSUdfTVREX1BI WVNNQVA9bQ0KQ09ORklHX01URF9QSFlTTUFQX0NPTVBBVD15DQpDT05GSUdfTVREX1BIWVNNQVBf T0Y9bQ0KQ09ORklHX01URF9JTVBBNz1tDQpDT05GSUdfTVREX1BDTUNJQT1tDQpDT05GSUdfTVRE X1BDTUNJQV9BTk9OWU1PVVM9eQ0KQ09ORklHX01URF9HUElPX0FERFI9eQ0KQ09ORklHX01URF9Q TEFUUkFNPXkNCkNPTkZJR19NVERfTEFUQ0hfQUREUj1tDQpDT05GSUdfTVREX0RBVEFGTEFTSD1t DQpDT05GSUdfTVREX0RBVEFGTEFTSF9XUklURV9WRVJJRlk9eQ0KQ09ORklHX01URF9EQVRBRkxB U0hfT1RQPXkNCkNPTkZJR19NVERfTTI1UDgwPW0NCkNPTkZJR19NVERfU1NUMjVMPW0NCkNPTkZJ R19NVERfU0xSQU09eQ0KQ09ORklHX01URF9QSFJBTT15DQpDT05GSUdfTVREX01URFJBTT15DQpD T05GSUdfTVREX0JMT0NLMk1URD1tDQpDT05GSUdfTVREX0RPQzIwMDA9bQ0KQ09ORklHX01URF9E T0MyMDAxPW0NCkNPTkZJR19NVERfRE9DMjAwMVBMVVM9bQ0KQ09ORklHX01URF9ET0NHMz1tDQpD T05GSUdfTVREX0RPQ1BST0JFX0FEVkFOQ0VEPXkNCkNPTkZJR19NVERfRE9DUFJPQkVfSElHSD15 DQpDT05GSUdfTVREX05BTkRfRUNDX1NNQz15DQpDT05GSUdfTVREX05BTkQ9eQ0KQ09ORklHX01U RF9OQU5EX1ZFUklGWV9XUklURT15DQpDT05GSUdfTVREX05BTkRfRUNDX0JDSD15DQpDT05GSUdf TVREX05BTkRfTVVTRVVNX0lEUz15DQpDT05GSUdfTVREX05BTkRfR1BJTz15DQpDT05GSUdfTVRE X05BTkRfRElTS09OQ0hJUD1tDQpDT05GSUdfTVREX05BTkRfRElTS09OQ0hJUF9CQlRXUklURT15 DQpDT05GSUdfTVREX05BTkRfRE9DRzQ9bQ0KQ09ORklHX01URF9OQU5EX0FUTUVMPW0NCkNPTkZJ R19NVERfTkFORF9OQU5EU0lNPXkNCkNPTkZJR19NVERfTkFORF9QTEFURk9STT1tDQpDT05GSUdf TVREX0FMQVVEQT1tDQpDT05GSUdfTVREX09ORU5BTkQ9eQ0KQ09ORklHX01URF9PTkVOQU5EX1ZF UklGWV9XUklURT15DQpDT05GSUdfTVREX09ORU5BTkRfR0VORVJJQz15DQpDT05GSUdfTVREX09O RU5BTkRfMlhfUFJPR1JBTT15DQpDT05GSUdfTVREX09ORU5BTkRfU0lNPW0NCkNPTkZJR19NVERf TFBERFI9eQ0KQ09ORklHX01URF9VQkk9eQ0KQ09ORklHX01URF9VQklfR0xVRUJJPW0NCiMgQ09O RklHX0JMS19ERVYgaXMgbm90IHNldA0KQ09ORklHX0lOUFVUX0ZGX01FTUxFU1M9eQ0KIyBDT05G SUdfSU5QVVRfTU9VU0VERVZfUFNBVVggaXMgbm90IHNldA0KIyBDT05GSUdfSU5QVVRfS0VZQk9B UkQgaXMgbm90IHNldA0KIyBDT05GSUdfSU5QVVRfTU9VU0UgaXMgbm90IHNldA0KIyBDT05GSUdf U0VSSU8gaXMgbm90IHNldA0KQ09ORklHX1ZUX0hXX0NPTlNPTEVfQklORElORz15DQojIENPTkZJ R19MRUdBQ1lfUFRZUyBpcyBub3Qgc2V0DQojIENPTkZJR19ERVZLTUVNIGlzIG5vdCBzZXQNCkNP TkZJR19TRVJJQUxfODI1MD15DQpDT05GSUdfU0VSSUFMXzgyNTBfQ09OU09MRT15DQpDT05GSUdf U0VSSUFMXzgyNTBfTlJfVUFSVFM9MzINCkNPTkZJR19TRVJJQUxfODI1MF9FWFRFTkRFRD15DQpD T05GSUdfU0VSSUFMXzgyNTBfTUFOWV9QT1JUUz15DQpDT05GSUdfU0VSSUFMXzgyNTBfU0hBUkVf SVJRPXkNCkNPTkZJR19TRVJJQUxfODI1MF9ERVRFQ1RfSVJRPXkNCkNPTkZJR19TRVJJQUxfODI1 MF9SU0E9eQ0KIyBDT05GSUdfSFdfUkFORE9NIGlzIG5vdCBzZXQNCkNPTkZJR19TUEk9eQ0KIyBD T05GSUdfSFdNT04gaXMgbm90IHNldA0KQ09ORklHX0RSTT15DQojIENPTkZJR19ISURfU1VQUE9S VCBpcyBub3Qgc2V0DQpDT05GSUdfVVNCPW0NCiMgQ09ORklHX0lPTU1VX1NVUFBPUlQgaXMgbm90 IHNldA0KQ09ORklHX1FVT1RBPXkNCiMgQ09ORklHX1BSSU5UX1FVT1RBX1dBUk5JTkcgaXMgbm90 IHNldA0KQ09ORklHX1FGTVRfVjI9eQ0KQ09ORklHX0pGRlMyX0ZTPXkNCiMgQ09ORklHX0pGRlMy X0ZTX1dSSVRFQlVGRkVSIGlzIG5vdCBzZXQNCkNPTkZJR19KRkZTMl9DT01QUkVTU0lPTl9PUFRJ T05TPXkNCkNPTkZJR19KRkZTMl9MWk89eQ0KQ09ORklHX0pGRlMyX1JVQklOPXkNCkNPTkZJR19K RkZTMl9DTU9ERV9GQVZPVVJMWk89eQ0KQ09ORklHX1VCSUZTX0ZTPW0NCkNPTkZJR19VQklGU19G U19BRFZBTkNFRF9DT01QUj15DQojIENPTkZJR19VQklGU19GU19aTElCIGlzIG5vdCBzZXQNCkNP TkZJR19VQklGU19GU19ERUJVRz15DQpDT05GSUdfTE9HRlM9bQ0KQ09ORklHX0NSQU1GUz1tDQpD T05GSUdfTkxTPXkNCkNPTkZJR19OTFNfREVGQVVMVD0idXRmOCINCkNPTkZJR19OTFNfQ09ERVBB R0VfNDM3PXkNCkNPTkZJR19OTFNfVVRGOD15DQpDT05GSUdfUFJJTlRLX1RJTUU9eQ0KIyBDT05G SUdfRU5BQkxFX1dBUk5fREVQUkVDQVRFRCBpcyBub3Qgc2V0DQpDT05GSUdfRlJBTUVfV0FSTj0y MDQ4DQpDT05GSUdfTUFHSUNfU1lTUlE9eQ0KQ09ORklHX0RFQlVHX0tFUk5FTD15DQojIENPTkZJ R19TQ0hFRF9ERUJVRyBpcyBub3Qgc2V0DQpDT05GSUdfU0NIRURTVEFUUz15DQpDT05GSUdfVElN RVJfU1RBVFM9eQ0KQ09ORklHX0RFQlVHX1NUQUNLX1VTQUdFPXkNCkNPTkZJR19CTEtfREVWX0lP X1RSQUNFPXkNCkNPTkZJR19DUllQVE89eQ0KIyBDT05GSUdfQ1JZUFRPX0FOU0lfQ1BSTkcgaXMg bm90IHNldA0KIyBDT05GSUdfQ1JZUFRPX0hXIGlzIG5vdCBzZXQNCg== --=-ZP2iOCOGIPAIjeAPBkCW-- --=-eQva3IeyZFgog+5NGU+s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAABAgAGBQJP6oLVAAoJECmIfjd9wqK0ockQAKiKIEHiAl/eFCiRT+QlivY1 KWwWdGcxwF0TM6XArG9kX9fzDxFAnu6/FpbKMivXmFJe58pt8ZQMc1PeOiImhQIT UeMfR6Od2JkxWf0sBTlhwye7xGXE4qF/qCYhmAonCk2d0Qw16in15cmGGTj84xqS 54xkC6CtzyaDPCoBOsAhpsCQ5yI1C7LIJczzdUfyMtlIx0Gxsr7iPHDFLReG2rli UmR49gNQj0o0jfYnw/N8kn1oO82tLUUDEp+5MUK7DRXf17Wf+h044isp2/pB6z6e R70gTMcPdeXlB0froJCXtb/uZ+t1a3km9orKJPZjw4X+SyaQWxmDbxSo07GST9mw G0U6NZyxJdtZDBQWnCZhKNCkvOUDvSbYCVuLtDV+V7P8oNFymcd5z3d+8GLtXYiy f637DdJoqc2hXYBbGoYtV8PD91agf2s1n/rMrRQCFF0d1KbM/s9/Wawur1XjS6mI bLfnjReBm/blNeI9h+FwPcsQ/fGVh8AelGtBUk+6JD+Ys3qeGAUB0m9kTQoO45RI t3Goxdpbqk96qCg+/LacFTw4yYaIzflrrt/Hjzyyy4rMcweGeQdgtvgs3W+ELMkN cuESYDNXeX7vGcx6Waxydg2Co5Fj7SAmfV8nHw+8QdZ/ZaB2oBNEprw+SvDWqnqa ZBs5Rn25f1LsYZ2iazpI =uJAt -----END PGP SIGNATURE----- --=-eQva3IeyZFgog+5NGU+s--