public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Shmulik Ladkani <shmulik.ladkani@gmail.com>
Cc: Richard Genoud <richard.genoud@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] ubi: Fix bad PEBs reserve caclulation
Date: Mon, 16 Jul 2012 18:33:57 +0300	[thread overview]
Message-ID: <1342452837.7270.15.camel@brekeke> (raw)
In-Reply-To: <1341389164-24409-1-git-send-email-shmulik.ladkani@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

On Wed, 2012-07-04 at 11:05 +0300, Shmulik Ladkani wrote:
> The existing mechanism of reserving PEBs for bad PEB handling has two
> flaws:
> - It is calculated as a percentage of good PEBs instead of total PEBs.
> - There's no limit on the amount of PEBs UBI reserves for future bad
>   eraseblock handling.

Thanks Shmulik - I did not have time to look at the patches, but the
overall description looks good. I will review the patches as soon as I
can. Thanks for making sense of this mess.

But one more think is the mtd web-site. I've grepped for '1%' and there
are plenty of them. I've changed them all to 2% more or less
mechanically - only cleaned up one section by removing out-of-date
information. Would you please grep for '2%' and review if the
information there is reasonable? Also, would you please add some more
info to this FAQ entry:

http://linux-mtd.infradead.org/faq/ubi.html#L_bad_blocks_exceeded

Or even better if you could write a separate section for this stuff in
the documentation, then you could remove that FAQ entry completely.

Thanks a lot!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2012-07-16 15:39 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-04  8:05 [PATCH 0/5] ubi: Fix bad PEBs reserve caclulation Shmulik Ladkani
2012-07-04  8:06 ` [PATCH 1/5] ubi: introduce ubi->bad_peb_limit Shmulik Ladkani
2012-07-18  7:09   ` Artem Bityutskiy
2012-07-18 10:40   ` Artem Bityutskiy
2012-07-19  6:16     ` Shmulik Ladkani
2012-07-30 13:00       ` Artem Bityutskiy
2012-07-04  8:06 ` [PATCH 2/5] ubi: Limit amount of reserved eraseblocks for bad PEB handling Shmulik Ladkani
2012-07-09 10:15   ` Richard Genoud
2012-07-09 11:02     ` Shmulik Ladkani
2012-07-18 10:28   ` Artem Bityutskiy
2012-07-18 11:01     ` Artem Bityutskiy
2012-07-18 19:55     ` Shmulik Ladkani
2012-07-19  3:35       ` Artem Bityutskiy
2012-07-18 11:40   ` Artem Bityutskiy
2012-07-04  8:06 ` [PATCH 3/5] ubi: kill CONFIG_MTD_UBI_BEB_RESERVE Shmulik Ladkani
2012-07-04  8:06 ` [PATCH 4/5] ubi: trivial: fix comment of ubi_calculate_reserved() Shmulik Ladkani
2012-07-18 10:38   ` Artem Bityutskiy
2012-07-04  8:06 ` [PATCH 5/5] ubi: harmonize the update of ubi->beb_rsvd_pebs Shmulik Ladkani
2012-07-18 11:32   ` Artem Bityutskiy
2012-07-04  8:35 ` [PATCH 0/5] ubi: Fix bad PEBs reserve caclulation Richard Weinberger
2012-07-04 11:33   ` Shmulik Ladkani
2012-07-06 15:27     ` Richard Genoud
2012-07-07  6:14       ` Shmulik Ladkani
2012-07-07  8:32         ` Richard Genoud
2012-07-09  6:58         ` Richard Genoud
2012-07-16 15:33 ` Artem Bityutskiy [this message]
2012-07-17  7:23   ` Shmulik Ladkani
2012-07-18  6:54     ` Artem Bityutskiy
2012-07-30 13:56 ` Artem Bityutskiy
2012-07-31  8:19   ` Shmulik Ladkani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1342452837.7270.15.camel@brekeke \
    --to=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard.genoud@gmail.com \
    --cc=richard@nod.at \
    --cc=shmulik.ladkani@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox