Re: [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA

Huang Shijie
2012-07-26T02:24:41Z

On Wed, Jul 25, 2012 at 11:23 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Jul 25, 2012 at 12:05 PM, Huang Shijie <shijie8@gmail.com> wrote:
>
>> Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q.
>> this patch makes the kernel built-in the mxs-dma, even the gpmi-nand
>> is not enabled.
>
> Well, as the driver currently stands: yes, it is needed.
>
> Without CONFIG_MXS_DMA, the GPMI driver cannot even be built.
But you have added "depend on MXS_DMA". So If you do not select the
mxs-dma, you can not see the
gpmi-nand.
that's why i think this patch is not needed.

Huang Shijie

>
> This is why I thought that 'select MXS_DMA' was the way to go, but
> according to the thread you pointed me at, it was Nacked by Shawn.
>
> Regards,
>
> Fabio Estevam