Re: [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA

Dong Aisheng
2012-07-26T02:29:30Z

On Thu, Jul 26, 2012 at 10:24:41AM +0800, Huang Shijie wrote:
> On Wed, Jul 25, 2012 at 11:23 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > On Wed, Jul 25, 2012 at 12:05 PM, Huang Shijie <shijie8@gmail.com> wrote:
> >
> >> Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q.
> >> this patch makes the kernel built-in the mxs-dma, even the gpmi-nand
> >> is not enabled.
> >
> > Well, as the driver currently stands: yes, it is needed.
> >
> > Without CONFIG_MXS_DMA, the GPMI driver cannot even be built.
> But you have added "depend on MXS_DMA". So If you do not select the
> mxs-dma, you can not see the
> gpmi-nand.
> that's why i think this patch is not needed.
>
How about using 'select MXS_DMA'?
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 31bb7e5..e7c3dcf 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -481,6 +481,7 @@ config MTD_NAND_NANDSIM
config MTD_NAND_GPMI_NAND
bool "GPMI NAND Flash Controller driver"
depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q)
+ select MXS_DMA
help

Then we do not need this patch and does not have the issue that MXS_DMA is
still compiled even GPMI_NAND is not selected.

Regards
Dong Aisheng