Re: [PATCH v2 3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA

Huang Shijie
2012-07-26T11:32:54Z

On Thu, Jul 26, 2012 at 7:08 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Jul 26, 2012 at 7:56 AM, Huang Shijie <shijie8@gmail.com> wrote:
>> On Thu, Jul 26, 2012 at 6:53 AM, Fabio Estevam <festevam@gmail.com> wrote:
>>> On Wed, Jul 25, 2012 at 11:24 PM, Huang Shijie <shijie8@gmail.com> wrote:
>>>
>>>> But you have added "depend on MXS_DMA". So If you do not select the
>>>> mxs-dma, you can not see the
>>>> gpmi-nand.
>>>> that's why i think this patch is not needed.
>>>
>>> So how CONFIG_MXS_DMA would be selected if not via defconfig?
>> Use the make menuconfig ARCH=arm:
>>
>> "device drivers"-->"DMA engine support" -->"mxs dma support"
>
> I prefer to have selected in the defconfig by default instead.
>
> It is not obvious for the end user that they need to manually select
> this option.
>
> mxs_defconfig also selects CONFIG_MXS_DMA.
In mx23/mx28, the mxs-dma has many users, so it's proper to make it default.

>
> Can't we do the same here and let imx_v6_v7_defconfig be built again?
Shawn, do you have any opinion about this?

Huang Shijie