Re: UBI fastmap updates

Richard Weinberger
2012-07-08T15:12:34Z

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Am 08.07.2012 14:07, schrieb Richard Weinberger:
> Hi Shmulik!
>
> Am 08.07.2012 13:47, schrieb Shmulik Ladkani:
>> +
>> + /* TODO: if find_fastmap==1, we do not enter this block at all.
>> + * shouldn't we? shouldn't we care of compatability of unknown
>> + * internal volumes OTHER than the fastmap ones, even if
>> + * find_fastmap==1?
>> + */
>> +
>
> If find_fastmap=1 we scan only the first 64 PEBs (now by using scan_peb()).
> When using fastmap can do not care about compatibility of unknown internal volumes
> at all.
> Fastmap keeps only track of known (and compatible volumes).
> Taking care of unknown internal volumes would imply a full scan.

Please forget the above statement.
We have to think of the case where no fastmap was found and the
64 scanned PEBs get reused by scan_all().
Thanks for pointing this out!

Thanks,
//richard

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]