From: Richard Genoud <richard.genoud@gmail.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Richard Genoud <richard.genoud@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] UBI: use a config value for default BEB limit
Date: Thu, 16 Aug 2012 16:54:31 +0200 [thread overview]
Message-ID: <1345128871-14939-1-git-send-email-richard.genoud@gmail.com> (raw)
In-Reply-To: <CACQ1gAhRYSYehym1qA_Oj71KU4fB2+1MEUGi5Wfnb+E=t3jcxA@mail.gmail.com>
This patch provides the possibility to adjust the default value for
"maximum expected number of bad blocks per 1024 blocks" from kernel
configuration.
sam9_l9260_defconfig has been adjusted as well. The nand device used by
this card has a NVB of 3996/4096 ie a MAX_BEB_LIMIT of 25/1024
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
arch/arm/configs/sam9_l9260_defconfig | 1 +
drivers/mtd/ubi/Kconfig | 29 +++++++++++++++++++++++++++++
drivers/mtd/ubi/ubi.h | 2 +-
3 files changed, 31 insertions(+), 1 deletions(-)
diff --git a/arch/arm/configs/sam9_l9260_defconfig b/arch/arm/configs/sam9_l9260_defconfig
index 47dd71a..2c20c9e 100644
--- a/arch/arm/configs/sam9_l9260_defconfig
+++ b/arch/arm/configs/sam9_l9260_defconfig
@@ -39,6 +39,7 @@ CONFIG_MTD_NAND=y
CONFIG_MTD_NAND_ATMEL=y
CONFIG_MTD_NAND_PLATFORM=y
CONFIG_MTD_UBI=y
+CONFIG_MTD_UBI_DEFAULT_BEB_LIMIT=25
CONFIG_MTD_UBI_GLUEBI=y
CONFIG_BLK_DEV_LOOP=y
CONFIG_BLK_DEV_RAM=y
diff --git a/drivers/mtd/ubi/Kconfig b/drivers/mtd/ubi/Kconfig
index 7a57cc0..30e8370 100644
--- a/drivers/mtd/ubi/Kconfig
+++ b/drivers/mtd/ubi/Kconfig
@@ -27,6 +27,35 @@ config MTD_UBI_WL_THRESHOLD
life-cycle less than 10000, the threshold should be lessened (e.g.,
to 128 or 256, although it does not have to be power of 2).
+config MTD_UBI_DEFAULT_BEB_LIMIT
+ int "Maximum expected bad eraseblock count per 1024 eraseblocks"
+ default 20
+ range 0 256
+ help
+ This option specifies the default value for maximum bad physical
+ eraseblocks UBI expects on the MTD device (per 1024 eraseblocks).
+ It will be used when the maximum bad PEB value is null in the
+ UBI_IOCATT ioctl (e.g. when calling ubiattach) or in the kernel
+ parameter ubi.mtd.
+ If the underlying flash does not admit of bad eraseblocks
+ (e.g. NOR flash), this value is ignored.
+
+ NAND datasheets often specify the minimum and maximum NVM (Number of
+ Valid Blocks) for the flashes' endurance lifetime. The maximum
+ expected bad eraseblocks per 1024 eraseblocks then can be calculated
+ as "1024 * (1 - MinNVB / MaxNVB)", which gives 20 for most NANDs
+ (MaxNVB is basically the total count of eraseblocks on the chip).
+
+ To put it differently, if this value is 20, UBI will try to reserve
+ about 1.9% of physical eraseblocks for bad blocks handling. And that
+ will be 1.9% of eraseblocks on the entire NAND chip, not just the MTD
+ partition UBI attaches. This means that if you have, say, a NAND
+ flash chip that admits a maximum 40 bad eraseblocks, and it is split
+ on two MTD partitions of the same size, UBI will reserve 40
+ eraseblocks when attaching a partition.
+
+ Leave the default value if unsure.
+
config MTD_UBI_GLUEBI
tristate "MTD devices emulation driver (gluebi)"
help
diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
index f926343..39a1e7e 100644
--- a/drivers/mtd/ubi/ubi.h
+++ b/drivers/mtd/ubi/ubi.h
@@ -51,7 +51,7 @@
#define UBI_NAME_STR "ubi"
/* Default number of maximum expected bad blocks per 1024 eraseblocks */
-#define MTD_UBI_DEFAULT_BEB_LIMIT 20
+#define MTD_UBI_DEFAULT_BEB_LIMIT CONFIG_MTD_UBI_DEFAULT_BEB_LIMIT
/* Normal UBI messages */
#define ubi_msg(fmt, ...) printk(KERN_NOTICE "UBI: " fmt "\n", ##__VA_ARGS__)
--
1.7.2.5
next prev parent reply other threads:[~2012-08-16 14:54 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 16:23 [PATCH 0/4] UBI: Use the whole NAND device to calculate max bad block number Richard Genoud
2012-07-10 16:23 ` [PATCH 1/4] mtd_is_partition: struct mtd_info should be const Richard Genoud
2012-08-15 14:02 ` Artem Bityutskiy
2012-07-10 16:23 ` [PATCH 2/4] MTD parts: introduce mtd_get_device_size() Richard Genoud
2012-07-10 16:23 ` [PATCH 3/4] UBI: use the whole MTD device size to get bad_peb_limit Richard Genoud
2012-07-18 6:50 ` Artem Bityutskiy
2012-07-18 8:30 ` Richard Genoud
2012-08-15 12:53 ` Artem Bityutskiy
2012-08-15 15:08 ` Artem Bityutskiy
2012-08-16 8:13 ` Richard Genoud
2012-08-16 12:00 ` Artem Bityutskiy
2012-08-16 8:25 ` Shmulik Ladkani
2012-08-16 10:35 ` Richard Genoud
2012-08-16 11:58 ` Artem Bityutskiy
2012-08-16 11:56 ` Artem Bityutskiy
2012-08-16 8:32 ` Shmulik Ladkani
2012-08-16 11:58 ` Artem Bityutskiy
2012-08-16 11:58 ` Richard Genoud
2012-07-10 16:23 ` [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter Richard Genoud
2012-08-15 14:57 ` Artem Bityutskiy
2012-08-16 14:52 ` [PATCH 0/2] splitting "UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter" Richard Genoud
2012-08-16 14:52 ` [PATCH 1/2] UBI: replace MTD_UBI_BEB_LIMIT with module parameter Richard Genoud
2012-08-17 8:22 ` Artem Bityutskiy
2012-08-17 10:27 ` Richard Genoud
2012-08-16 14:52 ` [PATCH 2/2] UBI: add ioctl for max_beb_per1024 Richard Genoud
2012-08-17 8:28 ` Artem Bityutskiy
2012-08-16 8:57 ` [PATCH 4/4] UBI: replace MTD_UBI_BEB_LIMIT with user-space parameter Shmulik Ladkani
2012-08-16 10:07 ` Richard Genoud
2012-08-16 10:42 ` Shmulik Ladkani
2012-08-16 13:33 ` Artem Bityutskiy
2012-08-19 7:09 ` Shmulik Ladkani
2012-08-19 19:04 ` Artem Bityutskiy
2012-08-20 6:55 ` Richard Genoud
2012-08-20 8:17 ` Artem Bityutskiy
2012-08-20 8:27 ` Richard Genoud
2012-08-16 13:28 ` Artem Bityutskiy
2012-08-16 13:50 ` Shmulik Ladkani
2012-08-16 14:30 ` Richard Genoud
2012-08-16 14:54 ` Richard Genoud [this message]
2012-08-17 7:34 ` Artem Bityutskiy
2012-08-17 7:06 ` Artem Bityutskiy
2012-07-10 16:23 ` [PATCH] ubiattach: introduce max_beb_per1024 in UBI_IOCATT Richard Genoud
2012-08-17 9:37 ` Artem Bityutskiy
2012-08-16 13:10 ` [PATCH 1/2] UBI: use the whole MTD device size to get bad_peb_limit Artem Bityutskiy
2012-08-16 13:10 ` [PATCH 2/2] arm: sam9_l9260_defconfig: adjust UBI bad eraseblocks limit Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345128871-14939-1-git-send-email-richard.genoud@gmail.com \
--to=richard.genoud@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox