From: Artem Bityutskiy <dedekind1@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
David.Woodhouse@intel.com, ben-linux@fluff.org,
patches@linaro.org
Subject: Re: [PATCH 6/6] mtd: s3c2410: Fix line over 80 characters warning
Date: Sun, 19 Aug 2012 14:11:20 +0300 [thread overview]
Message-ID: <1345374680.1832.5.camel@kyv> (raw)
In-Reply-To: <1342434747-27622-6-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On Mon, 2012-07-16 at 16:02 +0530, Sachin Kamat wrote:
> @@ -540,7 +540,8 @@ static void s3c2412_nand_enable_hwecc(struct mtd_info *mtd, int mode)
> unsigned long ctrl;
>
> ctrl = readl(info->regs + S3C2440_NFCONT);
> - writel(ctrl | S3C2412_NFCONT_INIT_MAIN_ECC, info->regs + S3C2440_NFCONT);
> + writel(ctrl | S3C2412_NFCONT_INIT_MAIN_ECC,
> + info->regs + S3C2440_NFCONT);
This patch makes the code look uglier and less readable. Please, align
the part which you move to thenext line with the opening bracket ("(").
The current code uses this style as well.
I did not take this patch.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-08-19 11:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-16 10:32 [PATCH 1/6] mtd: s3c2410: Use module_platform_driver() Sachin Kamat
2012-07-16 10:32 ` [PATCH 2/6] mtd: s3c2410: Use pr_* instead of printk Sachin Kamat
2012-08-19 11:07 ` Artem Bityutskiy
2012-07-16 10:32 ` [PATCH 3/6] mtd: s3c2410: Use <linux/io.h> instead of <asm/io.h> Sachin Kamat
2012-07-16 10:32 ` [PATCH 4/6] mtd: s3c2410: Do not initialise statics to 0 or NULL Sachin Kamat
2012-07-16 10:32 ` [PATCH 5/6] mtd: s3c2410: Fix checkpatch warnings and errors related to whitespaces Sachin Kamat
2012-08-19 11:08 ` Artem Bityutskiy
2012-07-16 10:32 ` [PATCH 6/6] mtd: s3c2410: Fix line over 80 characters warning Sachin Kamat
2012-08-19 11:11 ` Artem Bityutskiy [this message]
2012-08-21 4:51 ` Sachin Kamat
2012-08-03 4:47 ` [PATCH 1/6] mtd: s3c2410: Use module_platform_driver() Sachin Kamat
2012-08-08 9:30 ` Sachin Kamat
2012-08-16 5:23 ` Sachin Kamat
2012-08-17 12:46 ` Artem Bityutskiy
2012-08-18 6:21 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345374680.1832.5.camel@kyv \
--to=dedekind1@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=ben-linux@fluff.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).