From: Richard Genoud <richard.genoud@gmail.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Richard Genoud <richard.genoud@gmail.com>,
linux-mtd@lists.infradead.org,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: [PATCH v2 3/7] UBI: accept empty string for vid_hdr_offs parameter
Date: Mon, 20 Aug 2012 14:09:17 +0200 [thread overview]
Message-ID: <1345464561-24464-4-git-send-email-richard.genoud@gmail.com> (raw)
In-Reply-To: <1345464561-24464-1-git-send-email-richard.genoud@gmail.com>
as a new parameter (max_beb_per1024) will come in next patches, it's
better to accept empty string value so that we can do:
mtd.ubi=2,,25
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
drivers/mtd/ubi/build.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index 3c0b91f..cc0a4fa 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -1292,7 +1292,11 @@ static int __init bytes_str_to_int(const char *str)
unsigned long result;
result = simple_strtoul(str, &endp, 0);
- if (str == endp || result >= INT_MAX) {
+ if (str == endp)
+ /* empty string, assume it's 0 */
+ return 0;
+
+ if (result >= INT_MAX) {
printk(KERN_ERR "UBI error: incorrect bytes count: \"%s\"\n",
str);
return -EINVAL;
--
1.7.2.5
next prev parent reply other threads:[~2012-08-20 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 12:09 [PATCH v2 0/7] UBI: add max_beb_per1024 parameter / ioctl Richard Genoud
2012-08-20 12:09 ` [PATCH v2 1/7] UBI: prepare for max_beb_per1024 module parameter addition Richard Genoud
2012-08-20 12:26 ` Shmulik Ladkani
2012-08-20 12:09 ` [PATCH v2 2/7] UBI: change CONFIG_MTD_UBI_BEB_LIMIT range Richard Genoud
2012-08-20 12:09 ` Richard Genoud [this message]
2012-08-20 12:52 ` [PATCH v2 3/7] UBI: accept empty string for vid_hdr_offs parameter Shmulik Ladkani
2012-08-20 13:04 ` Artem Bityutskiy
2012-08-20 13:06 ` Richard Genoud
2012-08-21 20:19 ` Shmulik Ladkani
2012-08-22 8:51 ` Artem Bityutskiy
2012-08-20 12:09 ` [PATCH v2 4/7] UBI: check max_beb_per1024 value in ubi_attach_mtd_dev Richard Genoud
2012-08-20 12:09 ` [PATCH v2 5/7] UBI: replace MTD_UBI_BEB_LIMIT with module parameter Richard Genoud
2012-08-20 12:09 ` [PATCH v2 6/7] UBI: add ioctl for max_beb_per1024 Richard Genoud
2012-08-20 12:09 ` [PATCH v2 7/7] UBI: drop CONFIG_MTD_UBI_BEB_LIMIT Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345464561-24464-4-git-send-email-richard.genoud@gmail.com \
--to=richard.genoud@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox