From: Richard Genoud <richard.genoud@gmail.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Richard Genoud <richard.genoud@gmail.com>,
linux-mtd@lists.infradead.org,
Shmulik Ladkani <shmulik.ladkani@gmail.com>
Subject: [PATCH v2 4/7] UBI: check max_beb_per1024 value in ubi_attach_mtd_dev
Date: Mon, 20 Aug 2012 14:09:18 +0200 [thread overview]
Message-ID: <1345464561-24464-5-git-send-email-richard.genoud@gmail.com> (raw)
In-Reply-To: <1345464561-24464-1-git-send-email-richard.genoud@gmail.com>
max_beb_per1024 shouldn't be negative, and a 0 value will be treated as
the default value.
For the upper bound, 768/1024 should be enough.
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
drivers/mtd/ubi/build.c | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c
index cc0a4fa..1ddced3 100644
--- a/drivers/mtd/ubi/build.c
+++ b/drivers/mtd/ubi/build.c
@@ -49,6 +49,9 @@
/* Maximum number of comma-separated items in the 'mtd=' parameter */
#define MTD_PARAM_MAX_COUNT 2
+/* Maximum value for the number of bad eraseblocks per 1024 limit */
+#define MAX_MTD_UBI_BEB_LIMIT 768
+
#ifdef CONFIG_MTD_UBI_MODULE
#define ubi_is_module() 1
#else
@@ -855,6 +858,15 @@ int ubi_attach_mtd_dev(struct mtd_info *mtd, int ubi_num,
struct ubi_device *ubi;
int i, err, ref = 0;
+ if ((max_beb_per1024 < 0) || (max_beb_per1024 > MAX_MTD_UBI_BEB_LIMIT))
+ return -EINVAL;
+
+ /*
+ * Use the default value if max_beb_per1024 isn't provided.
+ */
+ if (!max_beb_per1024)
+ max_beb_per1024 = CONFIG_MTD_UBI_BEB_LIMIT;
+
/*
* Check if we already have the same MTD device attached.
*
--
1.7.2.5
next prev parent reply other threads:[~2012-08-20 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 12:09 [PATCH v2 0/7] UBI: add max_beb_per1024 parameter / ioctl Richard Genoud
2012-08-20 12:09 ` [PATCH v2 1/7] UBI: prepare for max_beb_per1024 module parameter addition Richard Genoud
2012-08-20 12:26 ` Shmulik Ladkani
2012-08-20 12:09 ` [PATCH v2 2/7] UBI: change CONFIG_MTD_UBI_BEB_LIMIT range Richard Genoud
2012-08-20 12:09 ` [PATCH v2 3/7] UBI: accept empty string for vid_hdr_offs parameter Richard Genoud
2012-08-20 12:52 ` Shmulik Ladkani
2012-08-20 13:04 ` Artem Bityutskiy
2012-08-20 13:06 ` Richard Genoud
2012-08-21 20:19 ` Shmulik Ladkani
2012-08-22 8:51 ` Artem Bityutskiy
2012-08-20 12:09 ` Richard Genoud [this message]
2012-08-20 12:09 ` [PATCH v2 5/7] UBI: replace MTD_UBI_BEB_LIMIT with module parameter Richard Genoud
2012-08-20 12:09 ` [PATCH v2 6/7] UBI: add ioctl for max_beb_per1024 Richard Genoud
2012-08-20 12:09 ` [PATCH v2 7/7] UBI: drop CONFIG_MTD_UBI_BEB_LIMIT Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345464561-24464-5-git-send-email-richard.genoud@gmail.com \
--to=richard.genoud@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox