From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH V2] mtd: basic (read only) driver for BCMA serial flash
Date: Sun, 16 Sep 2012 14:49:49 +0300 [thread overview]
Message-ID: <1347796189.2032.7.camel@kyv> (raw)
In-Reply-To: <CACna6ryroY=Xbv7+VsRfBYdhRd9P6uz935b9scQqCmTjneM7sQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1749 bytes --]
On Tue, 2012-09-11 at 12:35 +0200, Rafał Miłecki wrote:
> 2012/9/11 Artem Bityutskiy <dedekind1@gmail.com>:
> > On Mon, 2012-09-03 at 21:07 +0200, Rafał Miłecki wrote:
> >> This registers MTD driver for serial flash platform device. Right now it
> >> supports reading only, writing still has to be implemented.
> >> At this point it's marked as BROKEN, because it requires code present in
> >> net tree that wasn't mainlined yet.
> >>
> >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >
> > What are exactly the changes it depends on? URL? Are they staged for
> > 3.7?
>
> http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commitdiff;h=23cb3b2121323443834296a8ecb582b8aeb78d75
> http://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=commitdiff;h=d57ef3a6a2eeb88df47e892c66692e3f59722ffe
Please, remove "BROKEN" and re-send the compilable patch against the
l2-mtd.git tree. I've pulled Dave Miller's tree with your patches into
l2-mtd.git. Thanks!
> Well, I just didn't implement writing yet (it's more complicated than
> that trivial reads) and I didn't know the correct values for the above
> ones. I just set writesize to 1 to avoid some WARN/BUG (not remember
> right now).
OK. Just add 'mtd->writebufsize = mtd->writesize = 1; for now.
> In case some other driver handling platform device was loaded earlier.
> Is that wrong?
I do not really understand why you need this - can the general code
really call the removal method and the platform data be NULL? If not,
kill this check - if this happens, this is a bug and we'll end up with
an oops. If it can, please, explain in more details how this can
happen.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-09-16 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 19:07 [PATCH V2] mtd: basic (read only) driver for BCMA serial flash Rafał Miłecki
2012-09-11 10:20 ` Artem Bityutskiy
2012-09-11 10:35 ` Rafał Miłecki
2012-09-11 10:59 ` Artem Bityutskiy
2012-09-11 13:21 ` John W. Linville
2012-09-16 11:43 ` Artem Bityutskiy
2012-09-12 9:19 ` Rafał Miłecki
2012-09-16 11:49 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347796189.2032.7.camel@kyv \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).