From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: bcm47xxsflash: just use memcpy_fromio for reading
Date: Thu, 20 Sep 2012 15:22:31 +0300 [thread overview]
Message-ID: <1348143751.2388.16.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1348131625-24349-1-git-send-email-zajec5@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1928 bytes --]
On Thu, 2012-09-20 at 11:00 +0200, Rafał Miłecki wrote:
> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> ---
> It doesn't generate any errors on normal compilation, but I wasn't able
> to test it with "verify". This tool defeated me ;/
>
> First I cloned dedekind/maintaining.git but it didn't run because or
> lacking aiaiai.
>
> So I've cloned dedekind/aiaiai.git.
>
> Then I had to move aiaiai to ~/git/aiaiai to let "verify" find it.
>
> So I was able to use verify:
> time ./verify ../l2-mtd/ mips-bcm47xx_defconfig < ../l2-mtd/0001-mtd-bcm47xxsflash-just-use-memcpy-for-reading.patch
> but it didn't work because patch was already applied. My bad, but... it
> took 2m17.277s to verify to realize that. And that magic commit/message
> wasn't helpful:
Well, before doing anything with your tree, we clone it to a temporary
location (in the workdir, which can specify), that probably took 2
minutes in your machine.
> Failed to apply patch(es) with git am on top of:
> 0f1afc8 Quick fixes - applied by aiaiai
After this there should have been the right commit. But I agree this is
confusing, I'll look how I can improve this.
> So I've removed patch from my tree, and tried again. This time it took
> 3m14.398s just to display:
> [2012-09-20 10:39:10] aiaiai-make-kernel: Program "aiaiai-locker" is required but not found in PATH
>
> I just wanted to add ~/git/aiaiai to my $PATH, but noticed it doesn't contain
> aiaiai-locker anyway... I gave up :|
Because you need to type "make". This is written in the docs. Dunno, how
would I make sure users do not forget to type make before running? I can
improve the error message though, and put a hint there.
> I appreciate your work on additional quality tools, but apart from good
> code it also need to be easy-usable to make ppl use it :|
Thanks for feed-back, appreciated!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-20 12:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-20 9:00 [PATCH] mtd: bcm47xxsflash: just use memcpy_fromio for reading Rafał Miłecki
2012-09-20 12:22 ` Artem Bityutskiy [this message]
2012-09-20 12:45 ` Artem Bityutskiy
2012-09-20 13:23 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348143751.2388.16.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox