Re: [PATCH V3] mtd: basic (read only) driver for BCMA serial flash

[Artem Bityutskiy <dedekind1@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]

On Wed, 2012-09-26 at 09:55 +0200, Rafał Miłecki wrote:
> 2012/9/26 Artem Bityutskiy <dedekind1@gmail.com>:
> > On Mon, 2012-09-17 at 11:50 +0200, Rafał Miłecki wrote:
> >> This registers MTD driver for serial flash platform device. Right now it
> >> supports reading only, writing still has to be implemented.
> >>
> >> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
> >
> > Can you please confirm that you tested this and the driver works in R/O
> > mode just fine. If yes, I would also like to add a note that this is R/O
> > to the Kconfig text. If it does not even work, I am willing to drop it.
> 
> OFC it works! :) It nicely cooperates with bcm47xxpart (partitions are
> detected) and I can read mtd content (bootloader, nvram, etc.).
> 
> You're right, we miss info about R/O in Kconfig, I didn't think about this.

I've just folded the following changes in:

diff --git a/drivers/mtd/devices/Kconfig b/drivers/mtd/devices/Kconfig
index ce6e3d4..27f80cd 100644
--- a/drivers/mtd/devices/Kconfig
+++ b/drivers/mtd/devices/Kconfig
@@ -121,12 +121,12 @@ config MTD_SST25L
          if you want to specify device partitioning.
 
 config MTD_BCM47XXSFLASH
-       tristate "Support for serial flash on BCMA bus"
+       tristate "R/O support for serial flash on BCMA bus"
        depends on BCMA_SFLASH
        help
          BCMA bus can have various flash memories attached, they are
          registered by bcma as platform devices. This enables driver for
-         serial flash memories.
+         serial flash memories (only read-only mode is implemented).
 
 config MTD_SLRAM
        tristate "Uncached system RAM"


-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]