From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>,
Vikram Narayanan <vikram186@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: mtd_oobtest: printk -> pr_{info,err}
Date: Wed, 10 Oct 2012 17:40:23 +0300 [thread overview]
Message-ID: <1349880023.20594.36.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1348713422-16626-1-git-send-email-computersforpeace@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 658 bytes --]
On Wed, 2012-09-26 at 19:37 -0700, Brian Norris wrote:
> Use pr_info() and pr_err() while defining pr_fmt(). This saves a few
> characters, joins a few lines, and makes the code a little more readable
> (and grep-able).
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Not sure about this - there is a patch-set from Vikram Narayanan
<vikram186@gmail.com> (Subject: [RFC PATCH 0/8] mtd_tests: Remove
duplicate code and cleanups) which does this for all tests. I hoped he
can re-send newer version.
Also, this patch-set should probably merge all the split format strings
at the same time.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-10 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-27 2:37 [PATCH] mtd: mtd_oobtest: printk -> pr_{info,err} Brian Norris
2012-10-10 14:40 ` Artem Bityutskiy [this message]
2012-10-10 15:47 ` Vikram Narayanan
2012-10-10 16:29 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349880023.20594.36.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vikram186@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox