From: Artem Bityutskiy <dedekind1@gmail.com>
To: kyak <bas@bmail.ru>
Cc: Linux mtd <linux-mtd@lists.infradead.org>
Subject: Re: output file cannot be in the UBIFS root directory check is not working quite well
Date: Thu, 11 Oct 2012 09:01:54 +0300 [thread overview]
Message-ID: <1349935314.20594.40.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <alpine.LNX.2.02.1210101855001.1211@bas>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Wed, 2012-10-10 at 18:55 +0400, kyak wrote:
> Thanks Artem, your patch
> (http://lists.infradead.org/pipermail/linux-mtd/2012-October/044477.html)
> has fixed my problem as well.
Good!
> > Yes, it only needs to check if the output file is above the top level
> > of the input tree. But I guess it's not that easy - first things that come
> > into my mind are symbolic links and mount --bind.
This patch should take care of symbolic links - realpath should resolve
them. WRT bind-mounts - well, I consider this an unlikely case and it is
not a big deal if we do not detect this. mkfs.ubifs will fail somewhere
else, I guess, then.
But of course, I will not object if someone improves the check and
submits a patch.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-10-11 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 19:30 output file cannot be in the UBIFS root directory check is not working quite well kyak
2012-10-05 15:57 ` kyak
2012-10-08 13:57 ` Ricard Wanderlof
2012-10-08 14:40 ` kyak
2012-10-08 14:53 ` Ricard Wanderlof
2012-10-08 15:13 ` kyak
2012-10-10 14:55 ` kyak
2012-10-11 6:01 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349935314.20594.40.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=bas@bmail.ru \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox