Re: [PATCH] [MTD] Adjust the NOR CFI flash timeouts to round better

[David Woodhouse <dwmw2@infradead.org>]

[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]

On Mon, 2012-10-15 at 10:57 -0600, Jason Gunthorpe wrote:
> On Mon, Oct 15, 2012 at 09:09:40AM -0700, David Woodhouse wrote:
> 
> > So it's not *entirely* bogus, but it should certainly be cleaned up to
> > use the msecs_to_jiffies() helpers... or preferably not use jiffies at
> > all, perhaps.
> 
> No doubt this is part of why I've seen failures on my boards, the
> timeout is too short by half and rounded wrong :)

Yeah, the rounding by +2 is confusing. I'm sure it's wrong, but at least
I can kind of see where it came from.

> A quick grep shows many cases in drivers/mtd that use division of HZ,
> what would you like to see done here?

I'd like someone with infinite amounts of free time to go through and
clean them all up :)

> ?? That's '??s', not 'us', for next time the patch is submitted. Welcome
>   to the 21st century.
> 
> Hmm.. I may need a new terminal and/or mail reader ;)

As I said... welcome to the 21st century. Seriously though, what are you
using that isn't capable of even *preserving* UTF-8 when you reply to
it? That's really quite broken, and has been considered so for a decade
or more already.

-- 
dwmw2


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 6171 bytes --]