public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: linux-mtd@lists.infradead.org, Maxim Levitsky <maximlevitsky@gmail.com>
Subject: Re: [PATCH] mtd: sm_ftl: Remove unused kthread stuff
Date: Wed, 21 Nov 2012 17:05:54 +0200	[thread overview]
Message-ID: <1353510354.2701.10.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1352565322-8731-1-git-send-email-elezegarcia@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 773 bytes --]

On Sat, 2012-11-10 at 13:35 -0300, Ezequiel Garcia wrote:
> This driver uses workqueues, not kthreads.
> Remove kthread header and thread related comment.
> 
> Cc: Maxim Levitsky <maximlevitsky@gmail.com>
> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>

Aiaiai [1]! 

Aiaiai found out that this breaks the build!

drivers/mtd/sm_ftl.c:1025:2: error: implicit declaration of function 'IS_ERR' [-Werror=implicit-function-declaration]
drivers/mtd/sm_ftl.c:1026:3: error: implicit declaration of function 'PTR_ERR' [-Werror=implicit-function-declaration]

Include <linux/err.h> instead, I guess.

[1] git://git.infradead.org/users/dedekind/maintaining.git
    git://git.infradead.org/users/dedekind/aiaiai.git

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-11-21 15:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-10 16:35 [PATCH] mtd: sm_ftl: Remove unused kthread stuff Ezequiel Garcia
2012-11-21 15:05 ` Artem Bityutskiy [this message]
2012-11-22 23:02   ` Ezequiel Garcia
2012-11-30 13:07     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353510354.2701.10.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=elezegarcia@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=maximlevitsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox