From: Artem Bityutskiy <dedekind1@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, linux-mtd@lists.infradead.org,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [patch] UBIFS: use kmalloc_array() in recomp_data_node()
Date: Thu, 22 Nov 2012 12:31:37 +0200 [thread overview]
Message-ID: <1353580297.2701.29.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <20121117151126.GA16900@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
On Sat, 2012-11-17 at 18:11 +0300, Dan Carpenter wrote:
> out_len = le32_to_cpu(dn->size);
> - buf = kmalloc(out_len * WORST_COMPR_FACTOR, GFP_NOFS);
> + buf = kmalloc_array(out_len, WORST_COMPR_FACTOR, GFP_NOFS);
> if (!buf)
> return -ENOMEM;
I think this makes the code unreadable, because we really allocate a
buffer, not an array.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-11-22 10:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 15:11 [patch] UBIFS: use kmalloc_array() in recomp_data_node() Dan Carpenter
2012-11-22 10:31 ` Artem Bityutskiy [this message]
2012-11-22 11:14 ` Dan Carpenter
2012-11-22 11:24 ` Artem Bityutskiy
2012-11-22 12:33 ` Dan Carpenter
2012-11-22 14:48 ` Artem Bityutskiy
2012-11-22 16:41 ` Dan Carpenter
2012-11-22 11:26 ` Artem Bityutskiy
2012-11-22 11:29 ` Artem Bityutskiy
2012-11-22 12:09 ` Dan Carpenter
2012-11-22 11:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353580297.2701.29.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox