From: Artem Bityutskiy <dedekind1@gmail.com>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 4/5] ubi: Replace memcpy with struct assignment
Date: Mon, 03 Dec 2012 13:54:38 +0200 [thread overview]
Message-ID: <1354535678.30168.192.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1353671885-2287-1-git-send-email-elezegarcia@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Fri, 2012-11-23 at 08:58 -0300, Ezequiel Garcia wrote:
> This kind of memcpy() is error-prone. Its replacement with a struct
> assignment is prefered because it's type-safe and much easier to read.
>
> Found by coccinelle. Hand patched and reviewed.
> Tested by compilation only.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
Pushed to linux-ubi.git, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-12-03 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 11:58 [PATCH 4/5] ubi: Replace memcpy with struct assignment Ezequiel Garcia
2012-11-23 12:00 ` Ezequiel Garcia
2012-12-03 11:54 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354535678.30168.192.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=elezegarcia@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox