Re: [PATCH] nandsim: Introduce debugfs infrastructure

Artem Bityutskiy
2012-12-03T13:10:00Z

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On Sat, 2012-11-24 at 22:51 -0300, Ezequiel Garcia wrote:
> It's more user friendly to report debug information and statistics
> through debugfs, than to use printing facilites.
>
> This patch introduces a very minimal debugfs infrastructure
> and moves eraseblock wear report to an entry located at:
>
> /sys/kernel/debug/nandsim/wear_report
>
> This means we can remove rptwear option and just let
> the user read the wear report when we needs to.
>
> Cc: Artem Bityutskiy <dedekind1@gmail.com>
> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>

Looks good but would you please refactor it to get rid of the following
warnings identified by aiaiai:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/nand/nandsim.c:528:5: warning: no previous prototype for 'nandsim_debugfs_create' [-Wmissing-prototypes]
+drivers/mtd/nand/nandsim.c:528:5: warning: symbol 'nandsim_debugfs_create' was not declared. Should it be static? [sparse]
+drivers/mtd/nand/nandsim.c:564:6: warning: no previous prototype for 'nandsim_debugfs_remove' [-Wmissing-prototypes]
+drivers/mtd/nand/nandsim.c:564:6: warning: symbol 'nandsim_debugfs_remove' was not declared. Should it be static? [sparse]

--
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]