public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Harald Nordgard-Hansen <hhansen@pvv.org>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Fix recovery after failed write-buffer operation in cfi_cmdset_0002.c
Date: Mon, 03 Dec 2012 15:24:09 +0200	[thread overview]
Message-ID: <1354541049.11583.7.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <50AFF477.2030803@pvv.org>

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Fri, 2012-11-23 at 23:11 +0100, Harald Nordgard-Hansen wrote:
> > Would be nice to put a short comment about what you do and why, may
> > be some reference as well. Just to make sure if someone reads the
> > code, he/she has some clue what are these about.
> 
> Hopefully in place now.

Pushed to l2-mtd.git, thanks.

However, I had to do the following:

1. Make a commit message for you by copying parts of your e-mail.
2. Create a Signe-of-by for you.
3. Fix these checkpatch.pl warnings:

WARNING:LONG_LINE: line over 80 characters
#48: FILE: drivers/mtd/chips/cfi_cmdset_0002.c:1546:
+       cfi_send_gen_cmd(0xAA, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);

WARNING:LONG_LINE: line over 80 characters
#49: FILE: drivers/mtd/chips/cfi_cmdset_0002.c:1547:
+       cfi_send_gen_cmd(0x55, cfi->addr_unlock2, chip->start, map, cfi, cfi->device_type, NULL);

WARNING:LONG_LINE: line over 80 characters
#50: FILE: drivers/mtd/chips/cfi_cmdset_0002.c:1548:
+       cfi_send_gen_cmd(0xF0, cfi->addr_unlock1, chip->start, map, cfi, cfi->device_type, NULL);

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      reply	other threads:[~2012-12-03 13:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09 13:23 Fix recovery after failed write-buffer operation in cfi_cmdset_0002.c Harald Nordgard-Hansen
2012-11-21  7:48 ` Artem Bityutskiy
2012-11-23 22:11   ` Harald Nordgard-Hansen
2012-12-03 13:24     ` Artem Bityutskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354541049.11583.7.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=hhansen@pvv.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox