From: Richard Weinberger <richard@nod.at>
To: dedekind1@gmail.com
Cc: Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, zsadecki@itwatchdogs.com
Subject: [PATCH 1/2] ubi: Remove PEB from free tree in get_peb_for_wl()
Date: Mon, 3 Dec 2012 20:57:46 +0100 [thread overview]
Message-ID: <1354564667-9549-2-git-send-email-richard@nod.at> (raw)
In-Reply-To: <1354564667-9549-1-git-send-email-richard@nod.at>
If UBI is built without fastmap, get_peb_for_wl() has to
remove the PEB manially from the free tree.
Otherwise the requested PEB lives in two trees.
Reported-by: Zach Sadecki <zsadecki@itwatchdogs.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/mtd/ubi/wl.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
index da7b449..1f9f5f7 100644
--- a/drivers/mtd/ubi/wl.c
+++ b/drivers/mtd/ubi/wl.c
@@ -679,7 +679,13 @@ static struct ubi_wl_entry *get_peb_for_wl(struct ubi_device *ubi)
#else
static struct ubi_wl_entry *get_peb_for_wl(struct ubi_device *ubi)
{
- return find_wl_entry(ubi, &ubi->free, WL_FREE_MAX_DIFF);
+ struct ubi_wl_entry *e;
+
+ e = find_wl_entry(ubi, &ubi->free, WL_FREE_MAX_DIFF);
+ self_check_in_wl_tree(ubi, e, &ubi->free);
+ rb_erase(&e->u.rb, &ubi->free);
+
+ return e;
}
int ubi_wl_get_peb(struct ubi_device *ubi)
--
1.8.0
next prev parent reply other threads:[~2012-12-03 19:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 15:05 UBI wl_tree_add problems after PEB scrubbed Zach Sadecki
2012-12-03 10:48 ` Artem Bityutskiy
2012-12-03 11:01 ` Artem Bityutskiy
2012-12-03 11:19 ` Richard Weinberger
2012-12-03 14:46 ` Artem Bityutskiy
2012-12-03 15:02 ` Richard Weinberger
2012-12-03 15:33 ` Artem Bityutskiy
[not found] ` <1354564667-9549-1-git-send-email-richard@nod.at>
2012-12-03 19:57 ` Richard Weinberger [this message]
2012-12-04 8:34 ` [PATCH 1/2] ubi: Remove PEB from free tree in get_peb_for_wl() Artem Bityutskiy
2012-12-04 10:24 ` Richard Weinberger
2012-12-03 19:57 ` [PATCH 2/2] ubi: Dont call ubi_self_check_all_ff() in __wl_get_peb() Richard Weinberger
2012-12-04 7:55 ` Artem Bityutskiy
2012-12-04 7:56 ` Artem Bityutskiy
2012-12-04 8:15 ` Artem Bityutskiy
2012-12-04 9:15 ` Richard Weinberger
2012-12-04 14:45 ` UBI Fastmap fixes for 3.7 Zach Sadecki
2012-12-04 14:48 ` Richard Weinberger
2012-12-04 14:56 ` Zach Sadecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354564667-9549-2-git-send-email-richard@nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=zsadecki@itwatchdogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox