From: Artem Bityutskiy <dedekind1@gmail.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-mtd@lists.infradead.org, zsadecki@itwatchdogs.com
Subject: Re: [PATCH 2/2] ubi: Dont call ubi_self_check_all_ff() in __wl_get_peb()
Date: Tue, 04 Dec 2012 10:15:01 +0200 [thread overview]
Message-ID: <1354608901.11583.56.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1354607777.11583.50.camel@sauron.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]
On Tue, 2012-12-04 at 09:56 +0200, Artem Bityutskiy wrote:
> On Mon, 2012-12-03 at 20:57 +0100, Richard Weinberger wrote:
> > As ubi_self_check_all_ff() might sleep we are not allowed
> > to call it from atomic context.
> > For now we call it only from ubi_wl_get_peb().
> > There are some code paths where it would also make sense,
> > but these paths are currently atomic and only enabled
> > when fastmap is used.
> >
> > Signed-off-by: Richard Weinberger <richard@nod.at>
>
> Can you confirm that you enabled the 3 debugging options I sent and
> tested both FM and non-FM configurations with those options enabled?
Let me elaborate why I am asking.
1. If you did the tests and with this fix the debugging stuff works
fine, then it is OK to take this patch now and let you improve the FM
debugging coverage a bit later.
2. If you did not verify, then the assumption is _may_ be broken anyway,
then I would prefer to not take this patch, because I consider it to be
a band aid.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-12-04 8:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 15:05 UBI wl_tree_add problems after PEB scrubbed Zach Sadecki
2012-12-03 10:48 ` Artem Bityutskiy
2012-12-03 11:01 ` Artem Bityutskiy
2012-12-03 11:19 ` Richard Weinberger
2012-12-03 14:46 ` Artem Bityutskiy
2012-12-03 15:02 ` Richard Weinberger
2012-12-03 15:33 ` Artem Bityutskiy
[not found] ` <1354564667-9549-1-git-send-email-richard@nod.at>
2012-12-03 19:57 ` [PATCH 1/2] ubi: Remove PEB from free tree in get_peb_for_wl() Richard Weinberger
2012-12-04 8:34 ` Artem Bityutskiy
2012-12-04 10:24 ` Richard Weinberger
2012-12-03 19:57 ` [PATCH 2/2] ubi: Dont call ubi_self_check_all_ff() in __wl_get_peb() Richard Weinberger
2012-12-04 7:55 ` Artem Bityutskiy
2012-12-04 7:56 ` Artem Bityutskiy
2012-12-04 8:15 ` Artem Bityutskiy [this message]
2012-12-04 9:15 ` Richard Weinberger
2012-12-04 14:45 ` UBI Fastmap fixes for 3.7 Zach Sadecki
2012-12-04 14:48 ` Richard Weinberger
2012-12-04 14:56 ` Zach Sadecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354608901.11583.56.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=zsadecki@itwatchdogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox