public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Prins Anton (ST-CO/ENG1.1)" <Anton.Prins@nl.bosch.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: Patch to solve NULL pointer dereference in physmap_of.c
Date: Mon, 10 Dec 2012 15:31:19 +0200	[thread overview]
Message-ID: <1355146279.2657.32.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <85D877DD6EE67B4A9FCA9B9C3A4865670C3AFC5168@SI-MBX14.de.bosch.com>

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

On Mon, 2012-12-03 at 08:31 +0100, Prins Anton (ST-CO/ENG1.1) wrote:
> Sorry I'm in a learning curve... now used 'git format-patch'.
> This made it working for 'git am'; so hopefully this time its fine!
> 
> Artem, thanks for your support!

A lot better, but is still not ideal. You did not run checkpatch.pl,
otherwise you would notice this warning:

checkpatch.pl results for patch "[PATCH] mtd: maps/physmap_of.c: error checking to prevent a NULL  pointer dereference"                                                                                                             
                                                                                                                                                                                                                                    
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)                                                                                                                                                                              
                                                                                                                                                                                                                                    
total: 1 errors, 0 warnings, 19 lines checked                                                                                                                                                                                       

I've added the S-o-b line for you and pushed the patch to l2-mtd.git,
thanks!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-12-10 13:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09  7:45 Patch to solve NULL pointer dereference in physmap_of.c Prins Anton (ST-CO/ENG1.1)
2012-11-21  7:42 ` Artem Bityutskiy
2012-11-21  8:43   ` Prins Anton (ST-CO/ENG1.1)
2012-11-22 15:20   ` Prins Anton (ST-CO/ENG1.1)
2012-11-30 11:51     ` Artem Bityutskiy
2012-12-03  7:31       ` Prins Anton (ST-CO/ENG1.1)
2012-12-10 13:31         ` Artem Bityutskiy [this message]
2012-12-11  8:34           ` Prins Anton (ST-CO/ENG1.1)
2012-12-11  8:49             ` Artem Bityutskiy
2012-12-05 14:19       ` Prins Anton (ST-CO/ENG1.1)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1355146279.2657.32.camel@sauron.fi.intel.com \
    --to=dedekind1@gmail.com \
    --cc=Anton.Prins@nl.bosch.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox