minor einfo and mtd_debug improvement

minor einfo and mtd_debug improvement

[Larry Doolittle]

The following changes let einfo and mtd_debug do the right
thing when the underlying MTD device is marked readonly.

    - Larry


diff -ur mtd-util-20011003/einfo.c /home/ldoolitt/cvs/mtd/util/einfo.c
--- mtd-util-20011003/einfo.c	Mon Oct  1 15:42:08 2001
+++ /home/ldoolitt/cvs/mtd/util/einfo.c	Tue Apr 10 00:57:45 2001
@@ -20,7 +20,7 @@
 	}
    
 	// Open and size the device
-	if ((Fd = open(argv[1],O_RDONLY)) < 0)
+	if ((Fd = open(argv[1],O_RDWR)) < 0)
 	{
 		fprintf(stderr,"File open error\n");
 		return 8;
diff -ur mtd-util-20011003/mtd_debug.c /home/ldoolitt/cvs/mtd/util/mtd_debug.c
--- mtd-util-20011003/mtd_debug.c	Mon Oct  1 16:01:41 2001
+++ /home/ldoolitt/cvs/mtd/util/mtd_debug.c	Mon Jun 18 03:47:25 2001
@@ -357,7 +357,6 @@
 {
    const char *progname;
    int err = 0,fd,option = OPT_INFO;
-   int open_flag;
    (progname = strrchr (argv[0],'/')) ? progname++ : (progname = argv[0]);
 
    /* parse command-line options */
@@ -373,8 +372,7 @@
 	 showusage (progname);
 
    /* open device */
-   open_flag = (option==OPT_INFO || option==OPT_READ) ? O_RDONLY : O_RDWR;
-   if ((fd = open (argv[2],O_SYNC | open_flag)) < 0)
+   if ((fd = open (argv[2],O_SYNC | O_RDWR)) < 0)
 	 {
 		perror ("open()");
 		exit (1);

Re: minor einfo and mtd_debug improvement

[David Woodhouse]

ldoolitt@recycle.lbl.gov said:
>  The following changes let einfo and mtd_debug do the right thing when
> the underlying MTD device is marked readonly.

Thanks; applied. The patch was backwards - 'cvs diff -u' would have given 
better results.

--
dwmw2