From: Tormod Volden <lists.tormod@gmail.com>
To: linux-mtd@lists.infradead.org
Subject: [PATCH] mtd: nand: print source of "uncorrectable error" message
Date: Sat, 12 Jan 2013 00:43:55 +0100 [thread overview]
Message-ID: <1357947835-20194-1-git-send-email-lists.tormod@gmail.com> (raw)
From: Tormod Volden <debian.tormod@gmail.com>
Add the function name to the error message.
These messages are not very helpful:
[183356.176682] uncorrectable error :
[183356.180273] uncorrectable error :
[183356.184194] uncorrectable error :
[183356.187773] uncorrectable error :
[183356.191280] uncorrectable error :
Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
---
Not sure if above messages come from this code. I also believe there must be
a better way, advice welcome. Maybe we need to make sure all possible callers
print additional information if -1 is returned.
But this small change should be better than nothing, meanwhile.
Regards,
Tormod
drivers/mtd/nand/nand_ecc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/nand_ecc.c b/drivers/mtd/nand/nand_ecc.c
index b7cfe0d..cee06e9 100644
--- a/drivers/mtd/nand/nand_ecc.c
+++ b/drivers/mtd/nand/nand_ecc.c
@@ -507,7 +507,7 @@ int __nand_correct_data(unsigned char *buf,
if ((bitsperbyte[b0] + bitsperbyte[b1] + bitsperbyte[b2]) == 1)
return 1; /* error in ECC data; no action needed */
- printk(KERN_ERR "uncorrectable error : ");
+ printk(KERN_ERR "__nand_correct_data: uncorrectable error : ");
return -1;
}
EXPORT_SYMBOL(__nand_correct_data);
--
1.7.9.5
next reply other threads:[~2013-01-11 23:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 23:43 Tormod Volden [this message]
2013-01-12 9:01 ` [PATCH] mtd: nand: print source of "uncorrectable error" message Vikram Narayanan
2013-01-12 10:34 ` [PATCH v2] mtd/nand: Print source of error message Tormod Volden
2013-01-17 13:56 ` Artem Bityutskiy
2013-01-17 22:58 ` Tormod Volden
2013-01-18 10:18 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357947835-20194-1-git-send-email-lists.tormod@gmail.com \
--to=lists.tormod@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox