Re: [PATCH 1/2] mtd: gpmi: set the Golois Field bit for mx6q's BCH

Artem Bityutskiy
2013-02-04T08:31:28Z

[-- Attachment #1: Type: text/plain, Size: 607 bytes --]

On Fri, 2013-01-25 at 14:04 +0800, Huang Shijie wrote:
> +#define BF_BCH_FLASH0LAYOUT0_GF(v, x) \
> + ((GPMI_IS_MX6Q(x) && ((v) == 14)) \
> + ? (((1) << MX6Q_BP_BCH_FLASH0LAYOUT0_GF_13_14) \
> + & MX6Q_BM_BCH_FLASH0LAYOUT0_GF_13_14) \
> + : 0 \
> + )

Did you consider using static inline functions instead of macro
definitions? The added value would be at least type-checking. You would
also probably use names better than "v" and "x", you could even have
commentaries. Please, consider doing this.

Anyway, pushed to l2-mtd.git, thanks!

--
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]