Re: [PATCH 1/2] mtd: gpmi: set the Golois Field bit for mx6q's BCH

Huang Shijie
2013-02-04T09:11:37Z

于 2013年02月04日 16:31, Artem Bityutskiy 写道:
> On Fri, 2013-01-25 at 14:04 +0800, Huang Shijie wrote:
>> +#define BF_BCH_FLASH0LAYOUT0_GF(v, x) \
>> + ((GPMI_IS_MX6Q(x)&& ((v) == 14)) \
>> + ? (((1)<< MX6Q_BP_BCH_FLASH0LAYOUT0_GF_13_14) \
>> + & MX6Q_BM_BCH_FLASH0LAYOUT0_GF_13_14) \
>> + : 0 \
>> + )
> Did you consider using static inline functions instead of macro
These macros are only used when the different archs have different
definitions about
the some registers. Yes, it's ok to use the functions to replace them.

I am not sure if there is still a need to add the similar macros, if it
does, i can change to use
the inline functions.

thanks
Huang Shijie