From: "Rafał Miłecki" <zajec5@gmail.com>
To: linux-mtd@lists.infradead.org,
Artem Bityutskiy <dedekind1@gmail.com>,
David Woodhouse <David.Woodhouse@intel.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>
Subject: [PATCH V2 4/6] mtd: bcm47xxnflash: register this as normal driver
Date: Mon, 28 Jan 2013 11:25:48 +0100 [thread overview]
Message-ID: <1359368750-19763-4-git-send-email-zajec5@gmail.com> (raw)
In-Reply-To: <1359368750-19763-3-git-send-email-zajec5@gmail.com>
From: Hauke Mehrtens <hauke@hauke-m.de>
When platform_driver_probe() is used and no device is registered for
this driver -ENODEV is returned and and error message is shown. Not all
BCM47xx SoC have a nand flash chip controller and chip and for them an
error message was shown.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
V2: rebase after change in V2 of 3/6
---
drivers/mtd/nand/bcm47xxnflash/main.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/bcm47xxnflash/main.c b/drivers/mtd/nand/bcm47xxnflash/main.c
index 3e20762..a52acdc 100644
--- a/drivers/mtd/nand/bcm47xxnflash/main.c
+++ b/drivers/mtd/nand/bcm47xxnflash/main.c
@@ -77,6 +77,7 @@ static int bcm47xxnflash_remove(struct platform_device *pdev)
}
static struct platform_driver bcm47xxnflash_driver = {
+ .probe = bcm47xxnflash_probe,
.remove = bcm47xxnflash_remove,
.driver = {
.name = "bcma_nflash",
@@ -88,11 +89,7 @@ static int __init bcm47xxnflash_init(void)
{
int err;
- /*
- * Platform device "bcma_nflash" exists on SoCs and is registered very
- * early, it won't be added during runtime (use platform_driver_probe).
- */
- err = platform_driver_probe(&bcm47xxnflash_driver, bcm47xxnflash_probe);
+ err = platform_driver_register(&bcm47xxnflash_driver);
if (err)
pr_err("Failed to register bcm47xx nand flash driver: %d\n",
err);
--
1.7.10.4
next prev parent reply other threads:[~2013-01-28 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 10:25 [PATCH V2 3/6] mtd: bcm47xxnflash: fix message Rafał Miłecki
2013-01-28 10:25 ` Rafał Miłecki [this message]
2013-01-28 19:57 ` [PATCH V2 4/6] mtd: bcm47xxnflash: register this as normal driver Hauke Mehrtens
2013-02-04 8:35 ` [PATCH V2 3/6] mtd: bcm47xxnflash: fix message Artem Bityutskiy
2013-02-04 8:42 ` Rafał Miłecki
2013-02-04 9:02 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359368750-19763-4-git-send-email-zajec5@gmail.com \
--to=zajec5@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=dedekind1@gmail.com \
--cc=hauke@hauke-m.de \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox