[PATCH V2 3/6] mtd: bcm47xxnflash: fix message

[PATCH V2 3/6] mtd: bcm47xxnflash: fix message

[Rafał Miłecki]

From: Hauke Mehrtens <hauke@hauke-m.de>

This is not a serial flash driver, but a nand flash driver

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
V2: break line to match 80 chars
---
 drivers/mtd/nand/bcm47xxnflash/main.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/bcm47xxnflash/main.c b/drivers/mtd/nand/bcm47xxnflash/main.c
index 8363a9a..3e20762 100644
--- a/drivers/mtd/nand/bcm47xxnflash/main.c
+++ b/drivers/mtd/nand/bcm47xxnflash/main.c
@@ -94,7 +94,8 @@ static int __init bcm47xxnflash_init(void)
 	 */
 	err = platform_driver_probe(&bcm47xxnflash_driver, bcm47xxnflash_probe);
 	if (err)
-		pr_err("Failed to register serial flash driver: %d\n", err);
+		pr_err("Failed to register bcm47xx nand flash driver: %d\n",
+		       err);
 
 	return err;
 }
-- 
1.7.10.4

[PATCH V2 4/6] mtd: bcm47xxnflash: register this as normal driver

[Rafał Miłecki]

From: Hauke Mehrtens <hauke@hauke-m.de>

When platform_driver_probe() is used and no device is registered for
this driver -ENODEV is returned and and error message is shown. Not all
BCM47xx SoC have a nand flash chip controller and chip and for them an
error message was shown.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
V2: rebase after change in V2 of 3/6
---
 drivers/mtd/nand/bcm47xxnflash/main.c |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/mtd/nand/bcm47xxnflash/main.c b/drivers/mtd/nand/bcm47xxnflash/main.c
index 3e20762..a52acdc 100644
--- a/drivers/mtd/nand/bcm47xxnflash/main.c
+++ b/drivers/mtd/nand/bcm47xxnflash/main.c
@@ -77,6 +77,7 @@ static int bcm47xxnflash_remove(struct platform_device *pdev)
 }
 
 static struct platform_driver bcm47xxnflash_driver = {
+	.probe	= bcm47xxnflash_probe,
 	.remove = bcm47xxnflash_remove,
 	.driver = {
 		.name = "bcma_nflash",
@@ -88,11 +89,7 @@ static int __init bcm47xxnflash_init(void)
 {
 	int err;
 
-	/*
-	 * Platform device "bcma_nflash" exists on SoCs and is registered very
-	 * early, it won't be added during runtime (use platform_driver_probe).
-	 */
-	err = platform_driver_probe(&bcm47xxnflash_driver, bcm47xxnflash_probe);
+	err = platform_driver_register(&bcm47xxnflash_driver);
 	if (err)
 		pr_err("Failed to register bcm47xx nand flash driver: %d\n",
 		       err);
-- 
1.7.10.4

Re: [PATCH V2 4/6] mtd: bcm47xxnflash: register this as normal driver

[Hauke Mehrtens]

On 01/28/2013 11:25 AM, Rafał Miłecki wrote:
> From: Hauke Mehrtens <hauke@hauke-m.de>
> 
> When platform_driver_probe() is used and no device is registered for
> this driver -ENODEV is returned and and error message is shown. Not all
> BCM47xx SoC have a nand flash chip controller and chip and for them an
> error message was shown.
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> V2: rebase after change in V2 of 3/6

Thanks Rafał for taking this up.

Hauke

Re: [PATCH V2 3/6] mtd: bcm47xxnflash: fix message

[Artem Bityutskiy]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

On Mon, 2013-01-28 at 11:25 +0100, Rafał Miłecki wrote:
> From: Hauke Mehrtens <hauke@hauke-m.de>
> 
> This is not a serial flash driver, but a nand flash driver
> 
> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> ---
> V2: break line to match 80 chars

When sending v2 for individual patches, please, remember 2 things:

1. Keep them part of the original thread (ensure correct In-Reply-To:).
2. Add your own signed-off-by.

Thanks!

P.S. I took your versions of patches, thanks!

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH V2 3/6] mtd: bcm47xxnflash: fix message

[Rafał Miłecki]

2013/2/4 Artem Bityutskiy <dedekind1@gmail.com>:
> On Mon, 2013-01-28 at 11:25 +0100, Rafał Miłecki wrote:
>> From: Hauke Mehrtens <hauke@hauke-m.de>
>>
>> This is not a serial flash driver, but a nand flash driver
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>> V2: break line to match 80 chars
>
> When sending v2 for individual patches, please, remember 2 things:
>
> 1. Keep them part of the original thread (ensure correct In-Reply-To:).

Whoops, I've to learn how to make that with git send-email.


> 2. Add your own signed-off-by.

It was so trivial... I wasn't sure if it's worth signing-it-by... ;)

-- 
Rafał

Re: [PATCH V2 3/6] mtd: bcm47xxnflash: fix message

[Artem Bityutskiy]

[-- Attachment #1: Type: text/plain, Size: 1683 bytes --]

On Mon, 2013-02-04 at 09:42 +0100, Rafał Miłecki wrote:
> 2013/2/4 Artem Bityutskiy <dedekind1@gmail.com>:
> > On Mon, 2013-01-28 at 11:25 +0100, Rafał Miłecki wrote:
> >> From: Hauke Mehrtens <hauke@hauke-m.de>
> >>
> >> This is not a serial flash driver, but a nand flash driver
> >>
> >> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
> >> ---
> >> V2: break line to match 80 chars
> >
> > When sending v2 for individual patches, please, remember 2 things:
> >
> > 1. Keep them part of the original thread (ensure correct In-Reply-To:).
> 
> Whoops, I've to learn how to make that with git send-email.

 --in-reply-to=<identifier>

Pick the identifier from the Message-ID tag of the e-mail you are
replying to. E.g., save the e-mail as hauke.mbox file and do:

$ grep -i '^Message-ID:' hauke.mbox
Message-Id: <1359045599-1305-2-git-send-email-hauke@hauke-m.de>

which means that for this one the 'git send-email' option will be:

--in-reply-to="<1359045599-1305-2-git-send-email-hauke@hauke-m.de>"

> > 2. Add your own signed-off-by.
> 
> It was so trivial... I wasn't sure if it's worth signing-it-by... ;)

Signed-off-by is not about how big were your changes, it roughly
speaking means that you confirm that the source of this patch for you is
Hauke Mehrtens.

See Documentation/SubmittingPatches

The Signed-off-by: tag indicates that the signer was involved in the
development of the patch, or that he/she was in the patch's delivery
path.

I googled a bit and found also this:

http://kerneltrap.org/files/Jeremy/DCO.txt

which gives additional clue about what can be behind SOB.

-- 
Best Regards,
Artem Bityutskiy

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]