From: "Al Cooper" <alcooperx@gmail.com>
To: dwmw2@infradead.org, linux-mtd@lists.infradead.org
Cc: Al Cooper <alcooperx@gmail.com>
Subject: [PATCH] mtd: mtd_torturetest can cause stack overflows
Date: Mon, 4 Feb 2013 16:29:50 -0500 [thread overview]
Message-ID: <1360013390-30179-1-git-send-email-alcooperx@gmail.com> (raw)
In-Reply-To: <y>
mtd_torturetest uses the module parm "ebcnt" to control the size of a
stack based array of int's. When "ebcnt" is large, Ex: 1000, it
causes stack overflows on systems with small kernel stacks. The fix
is to move the array from the stack to kmalloc memory.
Signed-off-by: Al Cooper <alcooperx@gmail.com>
---
drivers/mtd/tests/mtd_torturetest.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/tests/mtd_torturetest.c b/drivers/mtd/tests/mtd_torturetest.c
index c4cde1e..a777cc8 100644
--- a/drivers/mtd/tests/mtd_torturetest.c
+++ b/drivers/mtd/tests/mtd_torturetest.c
@@ -208,7 +208,7 @@ static inline int write_pattern(int ebnum, void *buf)
static int __init tort_init(void)
{
int err = 0, i, infinite = !cycles_count;
- int bad_ebs[ebcnt];
+ int *bad_ebs;
printk(KERN_INFO "\n");
printk(KERN_INFO "=================================================\n");
@@ -273,6 +273,12 @@ static int __init tort_init(void)
goto out_patt_FF;
}
+ bad_ebs = kmalloc(sizeof(*bad_ebs) * ebcnt, GFP_KERNEL);
+ if (!bad_ebs) {
+ pr_err("error: cannot allocate memory\n");
+ goto out_check_buf;
+ }
+
err = 0;
/* Initialize patterns */
@@ -394,6 +400,8 @@ out:
pr_info("finished after %u erase cycles\n",
erase_cycles);
+ kfree(bad_ebs);
+out_check_buf:
kfree(check_buf);
out_patt_FF:
kfree(patt_FF);
--
1.7.6
next reply other threads:[~2013-02-04 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 21:29 Al Cooper [this message]
2013-02-05 2:05 ` [PATCH] mtd: mtd_torturetest can cause stack overflows Huang Shijie
2013-02-05 11:20 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360013390-30179-1-git-send-email-alcooperx@gmail.com \
--to=alcooperx@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox