public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: dwmw2@infradead.org,
	Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Daniel Mack <zonque@gmail.com>
Subject: [PATCH] mtd: devices: elm: check for device's presence before configuration
Date: Sun,  3 Mar 2013 22:12:58 +0100	[thread overview]
Message-ID: <1362345178-12536-1-git-send-email-zonque@gmail.com> (raw)

In case the driver is not probed - due to config mismatches or errors
in the DTS files - dev_get_drvdata() returns NULL, leading to an Ooops
during boot. Better bail out with a warning in such cases.

Signed-off-by: Daniel Mack <zonque@gmail.com>
Cc: Philip Avinash <avinashphilip@ti.com>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 drivers/mtd/devices/elm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index 2ec5da9..a9b6d04 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -86,6 +86,11 @@ void elm_config(struct device *dev, enum bch_ecc bch_type)
 	u32 reg_val;
 	struct elm_info *info = dev_get_drvdata(dev);
 
+	if (!info) {
+		dev_err(dev, "Unable to configure elm - device not probed?\n");
+		return;
+	}
+
 	reg_val = (bch_type & ECC_BCH_LEVEL_MASK) | (ELM_ECC_SIZE << 16);
 	elm_write_reg(info, ELM_LOCATION_CONFIG, reg_val);
 	info->bch_type = bch_type;
-- 
1.8.1.4

             reply	other threads:[~2013-03-03 21:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-03 21:12 Daniel Mack [this message]
2013-03-03 21:44 ` [PATCH] mtd: devices: elm: check for device's presence before configuration Peter Korsgaard
2013-03-03 22:03   ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362345178-12536-1-git-send-email-zonque@gmail.com \
    --to=zonque@gmail.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox