From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com ([143.182.124.21]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UCQCB-0005BG-Ed for linux-mtd@lists.infradead.org; Mon, 04 Mar 2013 07:52:28 +0000 Message-ID: <1362383434.2943.5.camel@sauron> Subject: Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{} From: Artem Bityutskiy To: Huang Shijie Date: Mon, 04 Mar 2013 09:50:34 +0200 In-Reply-To: <513437DF.2030505@freescale.com> References: <1359349039-11510-1-git-send-email-b32955@freescale.com> <1359349039-11510-2-git-send-email-b32955@freescale.com> <1360684037.12703.117.camel@sauron.fi.intel.com> <1362234094.2745.9.camel@sauron> <513437DF.2030505@freescale.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: dwmw2@infradead.org, computersforpeace@gmail.com, Huang Shijie , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org Reply-To: dedekind1@gmail.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote: > The current code uses the @id to store the device id(byte 1). > But if we use the 8 bytes id data as the keyword, and expand the @id > field to 8byte array, > the device id is the second byte now. All the added zeros are for the I do not think you need to store the full array of ID's. Device ID's for all the 4 of above chips are different, which is enough to distinguish between them. The only thing you need to add is the OOB size field to 'struct nand_flash_dev'. -- Best Regards, Artem Bityutskiy