public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>,
	Huang Shijie <b32955@freescale.com>
Cc: Mike Dunn <mikedunn@newsguy.com>,
	MTD Maling List <linux-mtd@lists.infradead.org>
Subject: [PATCH 01/12] mtd: nand_ids: minor clean-ups
Date: Mon,  4 Mar 2013 18:42:18 +0200	[thread overview]
Message-ID: <1362415349-7107-2-git-send-email-dedekind1@gmail.com> (raw)
In-Reply-To: <1362415349-7107-1-git-send-email-dedekind1@gmail.com>

From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

Clean-up the code a little bit:
  * clean-up commentaries.
  * move macro definitions to the top of the file.

Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
 drivers/mtd/nand/nand_ids.c |   26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c
index e3aa274..b110742 100644
--- a/drivers/mtd/nand/nand_ids.c
+++ b/drivers/mtd/nand/nand_ids.c
@@ -10,17 +10,17 @@
  */
 #include <linux/module.h>
 #include <linux/mtd/nand.h>
+
+#define LP_OPTIONS NAND_SAMSUNG_LP_OPTIONS
+#define LP_OPTIONS16 (LP_OPTIONS | NAND_BUSWIDTH_16)
+
 /*
-*	Chip ID list
-*
-*	Name. ID code, pagesize, chipsize in MegaByte, eraseblock size,
-*	options
-*
-*	Pagesize; 0, 256, 512
-*	0	get this information from the extended chip ID
-+	256	256 Byte page size
-*	512	512 Byte page size
-*/
+ * The chip ID list:
+ *    name, device ID, page size, chip size in MiB, eraseblock size, options
+ *
+ * If page size and eraseblock size is 0, the sizes are taken from the extended
+ * chip ID.
+ */
 struct nand_flash_dev nand_flash_ids[] = {
 
 #ifdef CONFIG_MTD_NAND_MUSEUM_IDS
@@ -67,11 +67,9 @@ struct nand_flash_dev nand_flash_ids[] = {
 	{"NAND 256MiB 3,3V 8-bit",	0x71, 512, 256, 0x4000, 0},
 
 	/*
-	 * These are the new chips with large page size. The pagesize and the
-	 * erasesize is determined from the extended id bytes
+	 * These are the new chips with large page size, page size and
+	 * eraseblock size is determined from the extended id bytes.
 	 */
-#define LP_OPTIONS NAND_SAMSUNG_LP_OPTIONS
-#define LP_OPTIONS16 (LP_OPTIONS | NAND_BUSWIDTH_16)
 
 	/* 512 Megabit */
 	{"NAND 64MiB 1,8V 8-bit",	0xA2, 0,  64, 0, LP_OPTIONS},
-- 
1.7.10.4

  reply	other threads:[~2013-03-04 16:41 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-04 16:42 [PATCH 00/12] mtd: nand: provision full ID support Artem Bityutskiy
2013-03-04 16:42 ` Artem Bityutskiy [this message]
2013-03-04 18:36   ` [PATCH 01/12] mtd: nand_ids: minor clean-ups Brian Norris
2013-03-05  8:32     ` Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 02/12] mtd: remove museum NAND ID's support Artem Bityutskiy
2013-03-04 18:37   ` Brian Norris
2013-03-05  6:23   ` Re[2]: " Alexander Shiyan
2013-03-04 16:42 ` [PATCH 03/12] arm: defconfigs: lpc32xx_defconfig: remove museum NAND option Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 04/12] mtd: nand: remove the rtc_from4 driver support Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 05/12] mtd: nand: remove AG-AND support Artem Bityutskiy
2013-03-04 18:56   ` Brian Norris
2013-03-05  8:37     ` Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 06/12] mtd: nand: remove a bunch of unused commands Artem Bityutskiy
2013-03-04 19:04   ` Brian Norris
2013-03-04 19:29   ` Re[2]: " Alexander Shiyan
2013-03-04 19:54     ` Brian Norris
2013-03-04 20:03       ` Re[4]: " Alexander Shiyan
2013-03-04 20:27         ` Brian Norris
2013-03-04 16:42 ` [PATCH 07/12] mtd: nand: remove NAND_NO_PADDING macro Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 08/12] mtd: nand: remove NAND_COPYBACK macro Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 09/12] mtd: nand: use NAND_HAS_CACHEPROG Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 10/12] mtd: nand_ids: introduce helper macros Artem Bityutskiy
2013-03-04 19:23   ` Brian Norris
2013-03-05 13:34     ` Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 11/12] mtd: nand: rename the id filed of 'struct nand_flash_dev' Artem Bityutskiy
2013-03-04 18:29   ` Brian Norris
2013-03-04 16:42 ` [PATCH 12/12] mtd: nand: provision full ID support Artem Bityutskiy
2013-03-04 16:50   ` Jan Lübbe
2013-03-04 19:45   ` Brian Norris
2013-03-05 10:37     ` Artem Bityutskiy
2013-03-06  5:32       ` Huang Shijie
2013-03-05  6:08   ` Huang Shijie
2013-03-05 10:42     ` Artem Bityutskiy
2013-03-05 14:36       ` Huang Shijie
2013-03-05 14:55         ` Artem Bityutskiy
2013-03-06  2:17           ` Huang Shijie
2013-03-04 19:48 ` [PATCH 00/12] " Brian Norris
2013-03-06  7:19   ` Artem Bityutskiy
2013-03-06  7:42     ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1362415349-7107-2-git-send-email-dedekind1@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mikedunn@newsguy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox