* Re: [PATCH 02/12] mtd: remove museum NAND ID's support [not found] <1362416362.801083474@f211.mail.ru> @ 2013-03-05 8:18 ` Artem Bityutskiy 2013-03-05 8:32 ` Re[2]: " Alexander Shiyan 0 siblings, 1 reply; 8+ messages in thread From: Artem Bityutskiy @ 2013-03-05 8:18 UTC (permalink / raw) To: Alexander Shiyan; +Cc: linux-mtd On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote: > >From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > >It is probably OK to remove support for really old NAND chips of 8MiB or > >smaller size. We had a separate configuration option for them: > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > >Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > >--- > > drivers/mtd/nand/Kconfig | 8 -------- > > drivers/mtd/nand/nand_ids.c | 19 ------------------- > > 2 files changed, 27 deletions(-) > > Hello. > This change break systems with these NAND-chips, for example > these IDs is used in old DiskOnChip devices. Do you have one of those and use them with modern kernels ? Which one is that? -- Best Regards, Artem Bityutskiy ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re[2]: [PATCH 02/12] mtd: remove museum NAND ID's support 2013-03-05 8:18 ` [PATCH 02/12] mtd: remove museum NAND ID's support Artem Bityutskiy @ 2013-03-05 8:32 ` Alexander Shiyan 2013-03-05 8:41 ` Artem Bityutskiy 2013-03-05 8:45 ` Re[2]: " Artem Bityutskiy 0 siblings, 2 replies; 8+ messages in thread From: Alexander Shiyan @ 2013-03-05 8:32 UTC (permalink / raw) To: artem.bityutskiy; +Cc: linux-mtd > On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote: > > >From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > > >It is probably OK to remove support for really old NAND chips of 8MiB or > > >smaller size. We had a separate configuration option for them: > > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > > > >Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > >--- > > > drivers/mtd/nand/Kconfig | 8 -------- > > > drivers/mtd/nand/nand_ids.c | 19 ------------------- > > > 2 files changed, 27 deletions(-) > > > > Hello. > > This change break systems with these NAND-chips, for example > > these IDs is used in old DiskOnChip devices. > > Do you have one of those and use them with modern kernels ? Which one is > that? Yes. ID used in the MD2800-D08. I specifically included a configuration option to support this chip ;) Unfortunately, I can not say the exact device ID now because all of such devices sent in production, and I have no more now. Of course, these devices are not in production at the moment, but they are still being sold. --- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re[2]: [PATCH 02/12] mtd: remove museum NAND ID's support 2013-03-05 8:32 ` Re[2]: " Alexander Shiyan @ 2013-03-05 8:41 ` Artem Bityutskiy 2013-03-05 8:46 ` Re[4]: " Alexander Shiyan 2013-03-05 8:45 ` Re[2]: " Artem Bityutskiy 1 sibling, 1 reply; 8+ messages in thread From: Artem Bityutskiy @ 2013-03-05 8:41 UTC (permalink / raw) To: Alexander Shiyan; +Cc: linux-mtd On Tue, 2013-03-05 at 12:32 +0400, Alexander Shiyan wrote: > > On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote: > > > >From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > > > > >It is probably OK to remove support for really old NAND chips of 8MiB or > > > >smaller size. We had a separate configuration option for them: > > > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > > > > > >Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > >--- > > > > drivers/mtd/nand/Kconfig | 8 -------- > > > > drivers/mtd/nand/nand_ids.c | 19 ------------------- > > > > 2 files changed, 27 deletions(-) > > > > > > Hello. > > > This change break systems with these NAND-chips, for example > > > these IDs is used in old DiskOnChip devices. > > > > Do you have one of those and use them with modern kernels ? Which one is > > that? > > Yes. ID used in the MD2800-D08. I specifically included a configuration option > to support this chip ;) Unfortunately, I can not say the exact device ID now because > all of such devices sent in production, and I have no more now. > Of course, these devices are not in production at the moment, but they are still > being sold. OK, probably we can cut on 4MiB boundary then? I mean kill support for 4MiB NANDs and less? -- Best Regards, Artem Bityutskiy ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re[4]: [PATCH 02/12] mtd: remove museum NAND ID's support 2013-03-05 8:41 ` Artem Bityutskiy @ 2013-03-05 8:46 ` Alexander Shiyan 0 siblings, 0 replies; 8+ messages in thread From: Alexander Shiyan @ 2013-03-05 8:46 UTC (permalink / raw) To: artem.bityutskiy; +Cc: linux-mtd > On Tue, 2013-03-05 at 12:32 +0400, Alexander Shiyan wrote: > > > On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote: > > > > >From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > > > > > > >It is probably OK to remove support for really old NAND chips of 8MiB or > > > > >smaller size. We had a separate configuration option for them: > > > > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > > > > > > > >Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > >--- > > > > > drivers/mtd/nand/Kconfig | 8 -------- > > > > > drivers/mtd/nand/nand_ids.c | 19 ------------------- > > > > > 2 files changed, 27 deletions(-) > > > > > > > > Hello. > > > > This change break systems with these NAND-chips, for example > > > > these IDs is used in old DiskOnChip devices. > > > > > > Do you have one of those and use them with modern kernels ? Which one is > > > that? > > > > Yes. ID used in the MD2800-D08. I specifically included a configuration option > > to support this chip ;) Unfortunately, I can not say the exact device ID now because > > all of such devices sent in production, and I have no more now. > > Of course, these devices are not in production at the moment, but they are still > > being sold. > > OK, probably we can cut on 4MiB boundary then? I mean kill support for > 4MiB NANDs and less? At least for me it is OK. Diskonchip devices is started from 8MB. I never seen chips less than 8MB same as Brian. --- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re[2]: [PATCH 02/12] mtd: remove museum NAND ID's support 2013-03-05 8:32 ` Re[2]: " Alexander Shiyan 2013-03-05 8:41 ` Artem Bityutskiy @ 2013-03-05 8:45 ` Artem Bityutskiy 2013-03-05 8:50 ` Re[4]: " Alexander Shiyan 1 sibling, 1 reply; 8+ messages in thread From: Artem Bityutskiy @ 2013-03-05 8:45 UTC (permalink / raw) To: Alexander Shiyan; +Cc: linux-mtd On Tue, 2013-03-05 at 12:32 +0400, Alexander Shiyan wrote: > > On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote: > > > >From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > > > > >It is probably OK to remove support for really old NAND chips of 8MiB or > > > >smaller size. We had a separate configuration option for them: > > > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > > > > > >Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > >--- > > > > drivers/mtd/nand/Kconfig | 8 -------- > > > > drivers/mtd/nand/nand_ids.c | 19 ------------------- > > > > 2 files changed, 27 deletions(-) > > > > > > Hello. > > > This change break systems with these NAND-chips, for example > > > these IDs is used in old DiskOnChip devices. > > > > Do you have one of those and use them with modern kernels ? Which one is > > that? > > Yes. ID used in the MD2800-D08. I specifically included a configuration option > to support this chip ;) Unfortunately, I can not say the exact device ID now because > all of such devices sent in production, and I have no more now. > Of course, these devices are not in production at the moment, but they are still > being sold. Or probably, we can kill NANDs with 256 byte page - they are really from the stone age, while the 512 bytes ones are at least from the copper age. -- Best Regards, Artem Bityutskiy ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re[4]: [PATCH 02/12] mtd: remove museum NAND ID's support 2013-03-05 8:45 ` Re[2]: " Artem Bityutskiy @ 2013-03-05 8:50 ` Alexander Shiyan 2013-03-05 9:03 ` Artem Bityutskiy 0 siblings, 1 reply; 8+ messages in thread From: Alexander Shiyan @ 2013-03-05 8:50 UTC (permalink / raw) To: artem.bityutskiy; +Cc: linux-mtd > On Tue, 2013-03-05 at 12:32 +0400, Alexander Shiyan wrote: > > > On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote: > > > > >From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > > > > > > >It is probably OK to remove support for really old NAND chips of 8MiB or > > > > >smaller size. We had a separate configuration option for them: > > > > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > > > > > > > >Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > >--- > > > > > drivers/mtd/nand/Kconfig | 8 -------- > > > > > drivers/mtd/nand/nand_ids.c | 19 ------------------- > > > > > 2 files changed, 27 deletions(-) > > > > > > > > Hello. > > > > This change break systems with these NAND-chips, for example > > > > these IDs is used in old DiskOnChip devices. > > > > > > Do you have one of those and use them with modern kernels ? Which one is > > > that? > > > > Yes. ID used in the MD2800-D08. I specifically included a configuration option > > to support this chip ;) Unfortunately, I can not say the exact device ID now because > > all of such devices sent in production, and I have no more now. > > Of course, these devices are not in production at the moment, but they are still > > being sold. > > Or probably, we can kill NANDs with 256 byte page - they are really from > the stone age, while the 512 bytes ones are at least from the copper > age. Hehe :) But, i suggest keep these definitions in the comments. --- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Re[4]: [PATCH 02/12] mtd: remove museum NAND ID's support 2013-03-05 8:50 ` Re[4]: " Alexander Shiyan @ 2013-03-05 9:03 ` Artem Bityutskiy 0 siblings, 0 replies; 8+ messages in thread From: Artem Bityutskiy @ 2013-03-05 9:03 UTC (permalink / raw) To: Alexander Shiyan; +Cc: linux-mtd On Tue, 2013-03-05 at 12:50 +0400, Alexander Shiyan wrote: > > On Tue, 2013-03-05 at 12:32 +0400, Alexander Shiyan wrote: > > > > On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote: > > > > > >From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > > > > > > > > >It is probably OK to remove support for really old NAND chips of 8MiB or > > > > > >smaller size. We had a separate configuration option for them: > > > > > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > > > > > > > > > >Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com> > > > > > >--- > > > > > > drivers/mtd/nand/Kconfig | 8 -------- > > > > > > drivers/mtd/nand/nand_ids.c | 19 ------------------- > > > > > > 2 files changed, 27 deletions(-) > > > > > > > > > > Hello. > > > > > This change break systems with these NAND-chips, for example > > > > > these IDs is used in old DiskOnChip devices. > > > > > > > > Do you have one of those and use them with modern kernels ? Which one is > > > > that? > > > > > > Yes. ID used in the MD2800-D08. I specifically included a configuration option > > > to support this chip ;) Unfortunately, I can not say the exact device ID now because > > > all of such devices sent in production, and I have no more now. > > > Of course, these devices are not in production at the moment, but they are still > > > being sold. > > > > Or probably, we can kill NANDs with 256 byte page - they are really from > > the stone age, while the 512 bytes ones are at least from the copper > > age. > > Hehe :) > But, i suggest keep these definitions in the comments. I want to go even further and just kill 256-bytes NAND p ages support altogether, as I believe this is completely useless. Being in linux MTD since 2005, I've never seen anyone using those. -- Best Regards, Artem Bityutskiy ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 00/12] mtd: nand: provision full ID support @ 2013-03-04 16:42 Artem Bityutskiy 2013-03-04 16:42 ` [PATCH 02/12] mtd: remove museum NAND ID's support Artem Bityutskiy 0 siblings, 1 reply; 8+ messages in thread From: Artem Bityutskiy @ 2013-03-04 16:42 UTC (permalink / raw) To: Brian Norris, Huang Shijie; +Cc: Mike Dunn, MTD Maling List From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> Hi, this is an RFC which adds full ID support provision which Huang can then use to solve his problem described here: http://thread.gmane.org/gmane.linux.kernel/1428345/focus=45290 But before adding full ID support, I cleaned up things a little and removed AG-AND support as part of the clean-up. Thanks, Artem. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 02/12] mtd: remove museum NAND ID's support 2013-03-04 16:42 [PATCH 00/12] mtd: nand: provision full ID support Artem Bityutskiy @ 2013-03-04 16:42 ` Artem Bityutskiy 2013-03-05 6:23 ` Re[2]: " Alexander Shiyan 0 siblings, 1 reply; 8+ messages in thread From: Artem Bityutskiy @ 2013-03-04 16:42 UTC (permalink / raw) To: Brian Norris, Huang Shijie; +Cc: Mike Dunn, MTD Maling List From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> It is probably OK to remove support for really old NAND chips of 8MiB or smaller size. We had a separate configuration option for them: CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> --- drivers/mtd/nand/Kconfig | 8 -------- drivers/mtd/nand/nand_ids.c | 19 ------------------- 2 files changed, 27 deletions(-) diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 81bf5e5..0f443ef 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -41,14 +41,6 @@ config MTD_SM_COMMON tristate default n -config MTD_NAND_MUSEUM_IDS - bool "Enable chip ids for obsolete ancient NAND devices" - default n - help - Enable this option only when your board has first generation - NAND chips (page size 256 byte, erase size 4-8KiB). The IDs - of these chips were reused by later, larger chips. - config MTD_NAND_DENALI tristate "Support Denali NAND controller" help diff --git a/drivers/mtd/nand/nand_ids.c b/drivers/mtd/nand/nand_ids.c index b110742..35070a2 100644 --- a/drivers/mtd/nand/nand_ids.c +++ b/drivers/mtd/nand/nand_ids.c @@ -22,25 +22,6 @@ * chip ID. */ struct nand_flash_dev nand_flash_ids[] = { - -#ifdef CONFIG_MTD_NAND_MUSEUM_IDS - {"NAND 1MiB 5V 8-bit", 0x6e, 256, 1, 0x1000, 0}, - {"NAND 2MiB 5V 8-bit", 0x64, 256, 2, 0x1000, 0}, - {"NAND 4MiB 5V 8-bit", 0x6b, 512, 4, 0x2000, 0}, - {"NAND 1MiB 3,3V 8-bit", 0xe8, 256, 1, 0x1000, 0}, - {"NAND 1MiB 3,3V 8-bit", 0xec, 256, 1, 0x1000, 0}, - {"NAND 2MiB 3,3V 8-bit", 0xea, 256, 2, 0x1000, 0}, - {"NAND 4MiB 3,3V 8-bit", 0xd5, 512, 4, 0x2000, 0}, - {"NAND 4MiB 3,3V 8-bit", 0xe3, 512, 4, 0x2000, 0}, - {"NAND 4MiB 3,3V 8-bit", 0xe5, 512, 4, 0x2000, 0}, - {"NAND 8MiB 3,3V 8-bit", 0xd6, 512, 8, 0x2000, 0}, - - {"NAND 8MiB 1,8V 8-bit", 0x39, 512, 8, 0x2000, 0}, - {"NAND 8MiB 3,3V 8-bit", 0xe6, 512, 8, 0x2000, 0}, - {"NAND 8MiB 1,8V 16-bit", 0x49, 512, 8, 0x2000, NAND_BUSWIDTH_16}, - {"NAND 8MiB 3,3V 16-bit", 0x59, 512, 8, 0x2000, NAND_BUSWIDTH_16}, -#endif - {"NAND 16MiB 1,8V 8-bit", 0x33, 512, 16, 0x4000, 0}, {"NAND 16MiB 3,3V 8-bit", 0x73, 512, 16, 0x4000, 0}, {"NAND 16MiB 1,8V 16-bit", 0x43, 512, 16, 0x4000, NAND_BUSWIDTH_16}, -- 1.7.10.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re[2]: [PATCH 02/12] mtd: remove museum NAND ID's support 2013-03-04 16:42 ` [PATCH 02/12] mtd: remove museum NAND ID's support Artem Bityutskiy @ 2013-03-05 6:23 ` Alexander Shiyan 0 siblings, 0 replies; 8+ messages in thread From: Alexander Shiyan @ 2013-03-05 6:23 UTC (permalink / raw) To: Brian Norris; +Cc: Huang Shijie, Mike Dunn, MTD Maling List, Artem Bityutskiy > On Mon, Mar 4, 2013 at 8:42 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote: > > From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > > > It is probably OK to remove support for really old NAND chips of 8MiB or > > smaller size. We had a separate configuration option for them: > > CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > I have never seen any of these NAND. So FWIW: > > Acked-by: Brian Norris <computersforpeace@gmail.com> My previous post on this topic did not go, so I will repeat: These chips are used in DiskOnChip and removing identifiers will lead to malfunction of systems using DiskOnChip as extra memory. --- ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-03-05 9:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1362416362.801083474@f211.mail.ru>
2013-03-05 8:18 ` [PATCH 02/12] mtd: remove museum NAND ID's support Artem Bityutskiy
2013-03-05 8:32 ` Re[2]: " Alexander Shiyan
2013-03-05 8:41 ` Artem Bityutskiy
2013-03-05 8:46 ` Re[4]: " Alexander Shiyan
2013-03-05 8:45 ` Re[2]: " Artem Bityutskiy
2013-03-05 8:50 ` Re[4]: " Alexander Shiyan
2013-03-05 9:03 ` Artem Bityutskiy
2013-03-04 16:42 [PATCH 00/12] mtd: nand: provision full ID support Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 02/12] mtd: remove museum NAND ID's support Artem Bityutskiy
2013-03-05 6:23 ` Re[2]: " Alexander Shiyan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox