Re: Re[4]: [PATCH 02/12] mtd: remove museum NAND ID's support

Artem Bityutskiy
2013-03-05T09:03:24Z

On Tue, 2013-03-05 at 12:50 +0400, Alexander Shiyan wrote:
> > On Tue, 2013-03-05 at 12:32 +0400, Alexander Shiyan wrote:
> > > > On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote:
> > > > > >From: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> > > > > >
> > > > > >It is probably OK to remove support for really old NAND chips of 8MiB or
> > > > > >smaller size. We had a separate configuration option for them:
> > > > > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch.
> > > > > >
> > > > > >Signed-off-by: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
> > > > > >---
> > > > > > drivers/mtd/nand/Kconfig | 8 --------
> > > > > > drivers/mtd/nand/nand_ids.c | 19 -------------------
> > > > > > 2 files changed, 27 deletions(-)
> > > > >
> > > > > Hello.
> > > > > This change break systems with these NAND-chips, for example
> > > > > these IDs is used in old DiskOnChip devices.
> > > >
> > > > Do you have one of those and use them with modern kernels ? Which one is
> > > > that?
> > >
> > > Yes. ID used in the MD2800-D08. I specifically included a configuration option
> > > to support this chip ;) Unfortunately, I can not say the exact device ID now because
> > > all of such devices sent in production, and I have no more now.
> > > Of course, these devices are not in production at the moment, but they are still
> > > being sold.
> >
> > Or probably, we can kill NANDs with 256 byte page - they are really from
> > the stone age, while the 512 bytes ones are at least from the copper
> > age.
>
> Hehe :)
> But, i suggest keep these definitions in the comments.

I want to go even further and just kill 256-bytes NAND p ages support
altogether, as I believe this is completely useless. Being in linux MTD
since 2005, I've never seen anyone using those.