From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>,
Mike Dunn <mikedunn@newsguy.com>,
MTD Maling List <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 05/12] mtd: nand: remove AG-AND support
Date: Tue, 05 Mar 2013 10:37:54 +0200 [thread overview]
Message-ID: <1362472674.2943.27.camel@sauron> (raw)
In-Reply-To: <CAN8TOE_unP1QVSTiOJdAf3LQ6zKYDLJ03ZRO7ZcDg0L72prnDw@mail.gmail.com>
On Mon, 2013-03-04 at 10:56 -0800, Brian Norris wrote:
> On Mon, Mar 4, 2013 at 8:42 AM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
> >
> > We have only one AG-AND driver and it was not touched since 2005. It looks
> > like AG-AND was not really make it to mass-production and can be considered
> > a dead technology.
>
> You might want to include in your commit message that BBT_AUTO_REFRESH
> was only needed for AG-AND. You drop it here (which is perfectly
> reasonable) but it is technically provided as a generic feature which
> *could* be used outside of AG-AND.
OK, will do, thanks!
> > @@ -22,7 +21,6 @@
> > * Enable cached programming for 2k page size chips
> > * Check, if mtd->ecctype should be set to MTD_ECC_HW
> > * if we have HW ECC support.
> > - * The AG-AND chips have nice features for speed improvement,
> > * which are not supported yet. Read / program 4 pages in one go.
> > * BBT table is not serialized, has to be fixed
> > *
>
> You cut this off mid-sentence. Did you mean to cut three lines here,
> instead of just one?
Oops.
> > - if ((state == FL_ERASING) && (chip->options & NAND_IS_AND))
> > - chip->cmdfunc(mtd, NAND_CMD_STATUS_MULTI, -1, -1);
> > - else
> > + if (state == FL_ERASING)
> > chip->cmdfunc(mtd, NAND_CMD_STATUS, -1, -1);
>
> This is not a precise refactor. All non-AND flash would previously
> have run the STATUS command, but now you make it only run when
> FL_ERASING. Shouldn't it just be an unconditional cmdfunc(STATUS)?
OOPS!
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-05 8:37 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-04 16:42 [PATCH 00/12] mtd: nand: provision full ID support Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 01/12] mtd: nand_ids: minor clean-ups Artem Bityutskiy
2013-03-04 18:36 ` Brian Norris
2013-03-05 8:32 ` Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 02/12] mtd: remove museum NAND ID's support Artem Bityutskiy
2013-03-04 18:37 ` Brian Norris
2013-03-05 6:23 ` Re[2]: " Alexander Shiyan
2013-03-04 16:42 ` [PATCH 03/12] arm: defconfigs: lpc32xx_defconfig: remove museum NAND option Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 04/12] mtd: nand: remove the rtc_from4 driver support Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 05/12] mtd: nand: remove AG-AND support Artem Bityutskiy
2013-03-04 18:56 ` Brian Norris
2013-03-05 8:37 ` Artem Bityutskiy [this message]
2013-03-04 16:42 ` [PATCH 06/12] mtd: nand: remove a bunch of unused commands Artem Bityutskiy
2013-03-04 19:04 ` Brian Norris
2013-03-04 19:29 ` Re[2]: " Alexander Shiyan
2013-03-04 19:54 ` Brian Norris
2013-03-04 20:03 ` Re[4]: " Alexander Shiyan
2013-03-04 20:27 ` Brian Norris
2013-03-04 16:42 ` [PATCH 07/12] mtd: nand: remove NAND_NO_PADDING macro Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 08/12] mtd: nand: remove NAND_COPYBACK macro Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 09/12] mtd: nand: use NAND_HAS_CACHEPROG Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 10/12] mtd: nand_ids: introduce helper macros Artem Bityutskiy
2013-03-04 19:23 ` Brian Norris
2013-03-05 13:34 ` Artem Bityutskiy
2013-03-04 16:42 ` [PATCH 11/12] mtd: nand: rename the id filed of 'struct nand_flash_dev' Artem Bityutskiy
2013-03-04 18:29 ` Brian Norris
2013-03-04 16:42 ` [PATCH 12/12] mtd: nand: provision full ID support Artem Bityutskiy
2013-03-04 16:50 ` Jan Lübbe
2013-03-04 19:45 ` Brian Norris
2013-03-05 10:37 ` Artem Bityutskiy
2013-03-06 5:32 ` Huang Shijie
2013-03-05 6:08 ` Huang Shijie
2013-03-05 10:42 ` Artem Bityutskiy
2013-03-05 14:36 ` Huang Shijie
2013-03-05 14:55 ` Artem Bityutskiy
2013-03-06 2:17 ` Huang Shijie
2013-03-04 19:48 ` [PATCH 00/12] " Brian Norris
2013-03-06 7:19 ` Artem Bityutskiy
2013-03-06 7:42 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362472674.2943.27.camel@sauron \
--to=dedekind1@gmail.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=mikedunn@newsguy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox