From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com ([143.182.124.21]) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UCnmN-0001o6-My for linux-mtd@lists.infradead.org; Tue, 05 Mar 2013 09:03:24 +0000 Message-ID: <1362474237.2943.34.camel@sauron> Subject: Re: Re[4]: [PATCH 02/12] mtd: remove museum NAND ID's support From: Artem Bityutskiy To: Alexander Shiyan Date: Tue, 05 Mar 2013 11:03:57 +0200 In-Reply-To: <1362473407.874036293@f171.mail.ru> References: <1362416362.801083474@f211.mail.ru> <1362472344.590520456@f357.mail.ru> <1362473121.2943.32.camel@sauron> <1362473407.874036293@f171.mail.ru> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Cc: linux-mtd@lists.infradead.org Reply-To: artem.bityutskiy@linux.intel.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2013-03-05 at 12:50 +0400, Alexander Shiyan wrote: > > On Tue, 2013-03-05 at 12:32 +0400, Alexander Shiyan wrote: > > > > On Mon, 2013-03-04 at 20:59 +0400, Alexander Shiyan wrote: > > > > > >From: Artem Bityutskiy > > > > > > > > > > > >It is probably OK to remove support for really old NAND chips of 8MiB or > > > > > >smaller size. We had a separate configuration option for them: > > > > > >CONFIG_MTD_NAND_MUSEUM_IDS, which we remove along with this patch. > > > > > > > > > > > >Signed-off-by: Artem Bityutskiy > > > > > >--- > > > > > > drivers/mtd/nand/Kconfig | 8 -------- > > > > > > drivers/mtd/nand/nand_ids.c | 19 ------------------- > > > > > > 2 files changed, 27 deletions(-) > > > > > > > > > > Hello. > > > > > This change break systems with these NAND-chips, for example > > > > > these IDs is used in old DiskOnChip devices. > > > > > > > > Do you have one of those and use them with modern kernels ? Which one is > > > > that? > > > > > > Yes. ID used in the MD2800-D08. I specifically included a configuration option > > > to support this chip ;) Unfortunately, I can not say the exact device ID now because > > > all of such devices sent in production, and I have no more now. > > > Of course, these devices are not in production at the moment, but they are still > > > being sold. > > > > Or probably, we can kill NANDs with 256 byte page - they are really from > > the stone age, while the 512 bytes ones are at least from the copper > > age. > > Hehe :) > But, i suggest keep these definitions in the comments. I want to go even further and just kill 256-bytes NAND p ages support altogether, as I believe this is completely useless. Being in linux MTD since 2005, I've never seen anyone using those. -- Best Regards, Artem Bityutskiy