From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-mtd@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH mtd-utils] flash_otp_write: fix format string warning
Date: Wed, 06 Mar 2013 11:19:06 +0200 [thread overview]
Message-ID: <1362561546.21850.24.camel@sauron> (raw)
In-Reply-To: <1361378469-18631-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Wed, 2013-02-20 at 17:41 +0100, Uwe Kleine-König wrote:
> diff --git a/flash_otp_write.c b/flash_otp_write.c
> index d407ebb..41cf1c5 100644
> --- a/flash_otp_write.c
> +++ b/flash_otp_write.c
> @@ -58,7 +58,7 @@ int main(int argc,char *argv[])
> return errno;
> }
>
> - printf("Writing OTP user data on %s at offset 0x%lx\n", argv[2], offset);
> + printf("Writing OTP user data on %s at offset 0x%lx\n", argv[2], (unsigned long)offset);
Thanks for the clean-up, but I think last time we discussed this we
agreed to use the new C99 "PRIx64" stuff, and introduced a helper
PRIdoff_t helper which we use for 'off_t' printing. See commit
56840a198a70604ece50d9d727cebcc28930ab4c for example.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-06 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 16:41 [PATCH mtd-utils] flash_otp_write: fix format string warning Uwe Kleine-König
2013-03-06 9:19 ` Artem Bityutskiy [this message]
2013-03-06 9:43 ` [PATCH v2] " Uwe Kleine-König
2013-03-06 11:10 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362561546.21850.24.camel@sauron \
--to=dedekind1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox