Re: [PATCH V2 1/3] mtd: bcm47xxsflash: keep a reference to the BCMA

Artem Bityutskiy
2013-03-06T11:13:16Z

On Wed, 2013-03-06 at 12:08 +0100, Rafał Miłecki wrote:
> 2013/3/6 Artem Bityutskiy <dedekind1@gmail.com>:
> > On Wed, 2013-03-06 at 12:01 +0100, Rafał Miłecki wrote:
> >> struct bcma_drv_cc;
> >> +
> >> struct bcm47xxsflash {
> >> + union {
> >> + struct bcma_drv_cc *bcma_cc;
> >> + };
> >
> > Why union?
>
> It's about adding support for different buses in the future (ssb) I
> was describing in the other patch.

Would be a bit cleaner to add the union when you add the second field
instead, or at least make sure you add the second field in this series.
Otherwise how do I know if you are going to ever send a patch which
justifies the union?

--
Best Regards,
Artem Bityutskiy