From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-mtd@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] flash_otp_write: fix format string warning
Date: Wed, 06 Mar 2013 13:10:39 +0200 [thread overview]
Message-ID: <1362568239.21850.29.camel@sauron> (raw)
In-Reply-To: <1362563020-14003-1-git-send-email-u.kleine-koenig@pengutronix.de>
On Wed, 2013-03-06 at 10:43 +0100, Uwe Kleine-König wrote:
> This fixes
> flash_otp_write.c: In function 'main':
> flash_otp_write.c:61:2: warning: format '%lx' expects argument of type 'long unsigned int', but argument 3 has type 'off_t' [-Wformat]
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wait, sorry, I did not notice this at first, but I see that this is
already fixed by this commit:
commit f3f3a208048eac5f8b5752a17ebcd44db9230fd8
Author: Richard Genoud <richard.genoud@gmail.com>
Date: Wed Sep 12 16:38:34 2012 +0200
consistency between u_int32_t / off_t / off64_t
We should use the off_t type instead of off64_t or u_int32_t as its
length is controlled by the WITHOUT_LARGEFILE flag.
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
--
Best Regards,
Artem Bityutskiy
prev parent reply other threads:[~2013-03-06 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 16:41 [PATCH mtd-utils] flash_otp_write: fix format string warning Uwe Kleine-König
2013-03-06 9:19 ` Artem Bityutskiy
2013-03-06 9:43 ` [PATCH v2] " Uwe Kleine-König
2013-03-06 11:10 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362568239.21850.29.camel@sauron \
--to=dedekind1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-mtd@lists.infradead.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox