From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
linux-mtd@lists.infradead.org,
David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [PATCH V2 1/3] mtd: bcm47xxsflash: keep a reference to the BCMA
Date: Wed, 06 Mar 2013 13:13:53 +0200 [thread overview]
Message-ID: <1362568433.21850.31.camel@sauron> (raw)
In-Reply-To: <CACna6ryh0Ko3edT_dSHcP6U21rmxAuHgc--Y=sK5e=z2pVPCmg@mail.gmail.com>
On Wed, 2013-03-06 at 12:08 +0100, Rafał Miłecki wrote:
> 2013/3/6 Artem Bityutskiy <dedekind1@gmail.com>:
> > On Wed, 2013-03-06 at 12:01 +0100, Rafał Miłecki wrote:
> >> struct bcma_drv_cc;
> >> +
> >> struct bcm47xxsflash {
> >> + union {
> >> + struct bcma_drv_cc *bcma_cc;
> >> + };
> >
> > Why union?
>
> It's about adding support for different buses in the future (ssb) I
> was describing in the other patch.
Would be a bit cleaner to add the union when you add the second field
instead, or at least make sure you add the second field in this series.
Otherwise how do I know if you are going to ever send a patch which
justifies the union?
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-06 11:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 11:01 [PATCH V2 1/3] mtd: bcm47xxsflash: keep a reference to the BCMA Rafał Miłecki
2013-03-06 11:01 ` [PATCH V2 2/3] mtd: bcm47xxsflash: store info about flash type Rafał Miłecki
2013-03-06 11:34 ` [PATCH V3 " Rafał Miłecki
2013-03-06 11:01 ` [PATCH 3/3] mtd: bcm47xxsflash: define opcodes Rafał Miłecki
2013-03-06 11:07 ` [PATCH V2 1/3] mtd: bcm47xxsflash: keep a reference to the BCMA Artem Bityutskiy
2013-03-06 11:08 ` Rafał Miłecki
2013-03-06 11:10 ` Rafał Miłecki
2013-03-06 11:13 ` Artem Bityutskiy [this message]
2013-03-06 11:33 ` [PATCH V3 " Rafał Miłecki
2013-03-13 10:58 ` [PATCH V2 " Artem Bityutskiy
2013-03-13 11:04 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362568433.21850.31.camel@sauron \
--to=dedekind1@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=hauke@hauke-m.de \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox