From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 2/3] mtd: add 4 Toshiba nand chips for the full-id case
Date: Wed, 13 Mar 2013 12:55:57 +0200 [thread overview]
Message-ID: <1363172157.11441.12.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1362653364-29993-3-git-send-email-b32955@freescale.com>
On Thu, 2013-03-07 at 18:49 +0800, Huang Shijie wrote:
> + /* TOSHIBA */
> + {"TC58NVG2S0F 4G 3.3V 8-bit",
> + { .id = {0x98, 0xdc, 0x90, 0x26, 0x76, 0x15, 0x01, 0x08}},
> + SZ_4K, SZ_512, SZ_256K, 0, 8, 224},
> + {"TC58NVG3S0F 8G 3.3V 8-bit",
> + { .id = {0x98, 0xd3, 0x90, 0x26, 0x76, 0x15, 0x02, 0x08}},
> + SZ_4K, SZ_1K, SZ_256K, 0, 8, 232},
> + {"TC58NVG5D2 32G 3.3V 8-bit",
> + { .id = {0x98, 0xd7, 0x94, 0x32, 0x76, 0x56, 0x09, 0x00}},
> + SZ_8K, SZ_4K, SZ_1M, 0, 8, 640},
> + {"TC58NVG6D2 64G 3.3V 8-bit",
> + { .id = {0x98, 0xde, 0x94, 0x82, 0x76, 0x56, 0x04, 0x20}},
> + SZ_8K, SZ_8K, SZ_2M, 0, 8, 640},
We need a useful comment above this block explaining that it is
important to have full ID records first.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-13 10:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 10:49 [PATCH V4 0/3] mtd: use the full-id as the keyword for some nand chips Huang Shijie
2013-03-07 10:49 ` [PATCH V4 1/3] mtd: add new fields to nand_flash_dev{} Huang Shijie
2013-03-13 10:54 ` Artem Bityutskiy
2013-03-13 13:04 ` Huang Shijie
2013-03-13 13:13 ` Artem Bityutskiy
2013-03-14 5:30 ` Brian Norris
2013-03-07 10:49 ` [PATCH V4 2/3] mtd: add 4 Toshiba nand chips for the full-id case Huang Shijie
2013-03-13 10:55 ` Artem Bityutskiy [this message]
2013-03-07 10:49 ` [PATCH V4 3/3] mtd: add the support to parse out the full-id nand type Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363172157.11441.12.camel@sauron.fi.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox