From: Artem Bityutskiy <dedekind1@gmail.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org,
Alexander Shiyan <shc_work@mail.ru>
Subject: Re: [RFC "v2"] mtd: nand: reintroduce NAND_NO_READRDY as NAND_NEED_READRDY
Date: Thu, 14 Mar 2013 12:41:44 +0200 [thread overview]
Message-ID: <1363257704.11441.102.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1363193491-1843-1-git-send-email-computersforpeace@gmail.com>
On Wed, 2013-03-13 at 09:51 -0700, Brian Norris wrote:
> + if (chip->options & NAND_NEED_READRDY) {
> + /* Apply delay or wait for ready/busy pin */
> + if (!chip->dev_ready)
> + udelay(chip->chip_delay);
> + else
> + nand_wait_ready(mtd);
> + }
Am I right that this is a small page NAND-specific thing? If yes, can we
just this magic to all small page NANDs without introducing the option?
Also, irrespectively of the final solution, let's do it this way:
1. Create a patch against the 3.9-rc2, not l2-mtd.git, and test it.
2. Add Cc stable, just like David asked.
2. Bug David to merge it.
3. I rebase the l2 tree on top of that.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-14 10:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 16:51 [RFC "v2"] mtd: nand: reintroduce NAND_NO_READRDY as NAND_NEED_READRDY Brian Norris
2013-03-13 16:53 ` Brian Norris
2013-03-13 17:17 ` Alexander Shiyan
2013-03-14 7:18 ` Alexander Shiyan
2013-03-14 10:32 ` David Woodhouse
2013-03-14 10:41 ` Artem Bityutskiy [this message]
2013-03-14 10:51 ` David Woodhouse
2013-03-14 12:52 ` David Woodhouse
2013-03-15 7:43 ` Alexander Shiyan
2013-03-15 17:27 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363257704.11441.102.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox