* [PATCH] mtd: omap2: fix IOERR
[not found] <CAGNmLEPEkre4SwbVgBYhDPhqC+tkn-aLp9-bTjh8dv90Yo6_tw@mail.gmail.com>
@ 2013-03-15 17:44 ` Brian Norris
2013-04-04 15:17 ` Artem Bityutskiy
2013-04-04 15:35 ` Artem Bityutskiy
0 siblings, 2 replies; 3+ messages in thread
From: Brian Norris @ 2013-03-15 17:44 UTC (permalink / raw)
To: linux-mtd; +Cc: Brian Norris, Toan Pham, Artem Bityutskiy
From: Toan Pham <tpham3783@gmail.com>
Fix mtd-utils from returning -EIO.
Formatting jffs2 filesystem was impossible when CONFIG_HZ was set to a low
value.
Signed-off-by: Toan Pham <tpham3783@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
Toan: it looks like your mailer uses MIME/HTML formatting, whereas the mailing
list expects plain text. It also seems your tabs were replaced with spaces. I
am resubmitting your patch for you, as it is simple and is not worth a lot more
email struggles. Thanks for the fix!
drivers/mtd/nand/omap2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index b97ef3b..81b80af 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -1023,9 +1023,9 @@ static int omap_wait(struct mtd_info *mtd, struct nand_chip *chip)
int status, state = this->state;
if (state == FL_ERASING)
- timeo += (HZ * 400) / 1000;
+ timeo += msecs_to_jiffies(400);
else
- timeo += (HZ * 20) / 1000;
+ timeo += msecs_to_jiffies(20);
writeb(NAND_CMD_STATUS & 0xFF, info->reg.gpmc_nand_command);
while (time_before(jiffies, timeo)) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: omap2: fix IOERR
2013-03-15 17:44 ` [PATCH] mtd: omap2: fix IOERR Brian Norris
@ 2013-04-04 15:17 ` Artem Bityutskiy
2013-04-04 15:35 ` Artem Bityutskiy
1 sibling, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2013-04-04 15:17 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, Toan Pham
On Fri, 2013-03-15 at 10:44 -0700, Brian Norris wrote:
> From: Toan Pham <tpham3783@gmail.com>
>
> Fix mtd-utils from returning -EIO.
> Formatting jffs2 filesystem was impossible when CONFIG_HZ was set to a low
> value.
>
> Signed-off-by: Toan Pham <tpham3783@gmail.com>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mtd: omap2: fix IOERR
2013-03-15 17:44 ` [PATCH] mtd: omap2: fix IOERR Brian Norris
2013-04-04 15:17 ` Artem Bityutskiy
@ 2013-04-04 15:35 ` Artem Bityutskiy
1 sibling, 0 replies; 3+ messages in thread
From: Artem Bityutskiy @ 2013-04-04 15:35 UTC (permalink / raw)
To: Brian Norris; +Cc: linux-mtd, Toan Pham
On Fri, 2013-03-15 at 10:44 -0700, Brian Norris wrote:
> From: Toan Pham <tpham3783@gmail.com>
>
> Fix mtd-utils from returning -EIO.
> Formatting jffs2 filesystem was impossible when CONFIG_HZ was set to a low
> value.
>
> Signed-off-by: Toan Pham <tpham3783@gmail.com>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Pushed to l2-mtd.git, thanks!
--
Best Regards,
Artem Bityutskiy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-04 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CAGNmLEPEkre4SwbVgBYhDPhqC+tkn-aLp9-bTjh8dv90Yo6_tw@mail.gmail.com>
2013-03-15 17:44 ` [PATCH] mtd: omap2: fix IOERR Brian Norris
2013-04-04 15:17 ` Artem Bityutskiy
2013-04-04 15:35 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).