From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
linux-mtd@lists.infradead.org,
David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: [PATCH] mtd: bcm47xxsflash: implement chip polling
Date: Tue, 19 Mar 2013 15:03:41 +0200 [thread overview]
Message-ID: <1363698221.14966.17.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <CACna6rxL5zV8xbJS3nwVi_w_4KXoR2uYKMCfNNEA8u6k1m22Dg@mail.gmail.com>
On Fri, 2013-03-15 at 17:43 +0100, Rafał Miłecki wrote:
> To be honest, I had bus abstraction in my code. I removed it because
> of Artem's comments in last patchset. He said he doesn't have a proof
> I'll ever add SSB support and told me to remove code that prepared
> bcm47xxsflash for abstracting bus type.
I only asked to introduce it when you actually need it. I only objected
to adding preparations without the code which uses the preparations. I
do not really know the bcm47 HW, but of course if you have a HW resource
which is shared between subsystems, you should not use it directly from
MTD, you should have some kind of framework / accessors for the
resource.
--
Best Regards,
Artem Bityutskiy
next prev parent reply other threads:[~2013-03-19 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 10:31 [PATCH] mtd: bcm47xxsflash: implement chip polling Rafał Miłecki
2013-03-15 16:26 ` Hauke Mehrtens
2013-03-15 16:43 ` Rafał Miłecki
2013-03-19 13:03 ` Artem Bityutskiy [this message]
2013-03-19 13:08 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1363698221.14966.17.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=hauke@hauke-m.de \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox